From 0b1b95cbf24efc188d21a241764c6f7473ea4858 Mon Sep 17 00:00:00 2001
From: Monty Taylor <mordred@inaugust.com>
Date: Thu, 12 Oct 2017 16:12:44 -0500
Subject: [PATCH] Switch success to false if a post playbook fails

We already have sucess false if pre playbooks fail. We only don't set it
for post playbooks.

Change-Id: I2d6071bf9d07a2695c81017d570ad4697801499f
---
 zuul/executor/server.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/zuul/executor/server.py b/zuul/executor/server.py
index b22be60863..d739c18957 100644
--- a/zuul/executor/server.py
+++ b/zuul/executor/server.py
@@ -1225,6 +1225,7 @@ class AnsibleJob(object):
             post_status, post_code = self.runAnsiblePlaybook(
                 playbook, args['timeout'], success, phase='post', index=index)
             if post_status != self.RESULT_NORMAL or post_code != 0:
+                success = False
                 # If we encountered a pre-failure, that takes
                 # precedence over the post result.
                 if not pre_failed: