From 487c6700b628cb5a02b8d7a66a793f5b3168a4db Mon Sep 17 00:00:00 2001
From: "James E. Blair" <jim@acmegating.com>
Date: Sat, 22 Feb 2025 09:38:50 -0800
Subject: [PATCH] Remove session listener when stopping tree cache

To better clean up the tree cache when stopping, remove the session
listener callback.  This helps avoid extra object references that
could keep the python objects from being garbage collected longer
than necessary.

Change-Id: I123624b531ca34b10394a23397dcfe932c3fa7e7
---
 zuul/zk/cache.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/zuul/zk/cache.py b/zuul/zk/cache.py
index e96ba1223a..f106b39ec8 100644
--- a/zuul/zk/cache.py
+++ b/zuul/zk/cache.py
@@ -138,6 +138,7 @@ class ZuulTreeCache(abc.ABC):
         self._stopped = True
         self._event_queue.put(None)
         self._playback_queue.put(None)
+        self.client.remove_listener(self._sessionListener)
 
     def _walkTree(self, root=None, seen_paths=None):
         # Recursively walk the tree and emit fake changed events for