zuul/zuul
Code Issues Proposed changes

Always report the build page

Browse Source 
Now that the Zuul web server and database are both required, provide
a consistent user experience by always reporting the build page.

This means that success-url and failure-url are no longer useful,
so remove them.

Update the quick-start to reflect that the build page is always
reported.

Change-Id: I4ff108df3917c9b6f44e2f5b0ccc4a7adbda1677
This commit is contained in:
James E. Blair
2021-07-08 13:45:55 -07:00
parent 6ea0f1a4f5
commit 1ee99f2fb2
29 changed files with 115 additions and 372 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tests/fixtures/config/ansible/git/common-config/zuul.yaml vendored
View File

@@ -79,14 +79,8 @@
- name: test_node
label: test_label
- job:
name: base-urls
success-url: https://success.example.com/zuul-logs/{build.uuid}/
failure-url: https://failure.example.com/zuul-logs/{build.uuid}/
- job:
name: python27
parent: base-urls
run: playbooks/python27.yaml
pre-run: playbooks/pre.yaml
post-run: playbooks/post.yaml
@@ -236,7 +230,6 @@
- ubuntu-xenial
- job:
parent: base-urls
name: hello
run: playbooks/hello-post.yaml
post-run: playbooks/hello-post.yaml

2
tests/fixtures/config/build-page/main.yaml vendored
View File

@@ -1,7 +1,6 @@
- tenant:
name: tenant-one
web-root: https://one.example.com/
report-build-page: true
source:
gerrit:
config-projects:
@@ -11,7 +10,6 @@
- tenant:
name: tenant-two
report-build-page: true
source:
gerrit:
config-projects:

1
tests/fixtures/config/data-return/git/common-config/zuul.yaml vendored
View File

@@ -34,7 +34,6 @@
- job:
name: data-return-relative
success-url: docs/index.html
run: playbooks/data-return-relative.yaml
- job:

2
tests/fixtures/config/mqtt-driver-report-build-page/git/common-config/playbooks/test.yaml vendored
View File

@@ -1,2 +0,0 @@
- hosts: all
tasks: []

45
tests/fixtures/config/mqtt-driver-report-build-page/git/common-config/zuul.d/config.yaml vendored
View File

@@ -1,45 +0,0 @@
- pipeline:
name: check
manager: independent
trigger:
gerrit:
- event: patchset-created
start:
mqtt:
topic: "{tenant}/zuul_start/{pipeline}/{project}/{branch}"
success:
gerrit:
Verified: 1
mqtt:
topic: "{tenant}/zuul_buildset/{pipeline}/{project}/{branch}"
failure:
gerrit:
Verified: -1
mqtt:
topic: "{tenant}/zuul_buildset/{pipeline}/{project}/{branch}"
- job:
name: base
parent: null
- job:
name: test
run: playbooks/test.yaml
- job:
name: dependent-test
run: playbooks/test.yaml
- project:
name: org/project
check:
jobs:
- test
- dependent-test:
dependencies:
- test
- project:
name: common-config
check:
jobs: []

1
tests/fixtures/config/mqtt-driver-report-build-page/git/org_project/README vendored
View File

@@ -1 +0,0 @@
test

9
tests/fixtures/config/mqtt-driver-report-build-page/main.yaml vendored
View File

@@ -1,9 +0,0 @@
- tenant:
name: tenant-one
report-build-page: true
source:
gerrit:
config-projects:
- common-config
untrusted-projects:
- org/project

2
tests/fixtures/config/success-url/git/common-config/playbooks/docs-draft-test.yaml vendored
View File

@@ -1,2 +0,0 @@
- hosts: all
tasks: []

2
tests/fixtures/config/success-url/git/common-config/playbooks/docs-draft-test2.yaml vendored
View File

@@ -1,2 +0,0 @@
- hosts: all
tasks: []

38
tests/fixtures/config/success-url/git/common-config/zuul.yaml vendored
View File

@@ -1,38 +0,0 @@
- pipeline:
name: check
manager: independent
trigger:
gerrit:
- event: patchset-created
start:
smtp:
to: alternative_me@example.com
success:
gerrit:
Verified: 1
smtp:
to: alternative_me@example.com
failure:
gerrit:
Verified: -1
- job:
name: base
parent: null
- job:
name: docs-draft-test
success-url: http://docs-draft.example.org/{change.number:.2}/{change.number}/{change.patchset}/{pipeline.name}/{job.name}/{build.uuid:.7}/publish-docs/
run: playbooks/docs-draft-test.yaml
- job:
name: docs-draft-test2
success-url: http://docs-draft.example.org/{NOPE}/{build.parameters[BAD]}/publish-docs/
run: playbooks/docs-draft-test2.yaml
- project:
name: org/docs
check:
jobs:
- docs-draft-test
- docs-draft-test2

1
tests/fixtures/config/success-url/git/org_docs/README vendored
View File

@@ -1 +0,0 @@
test

8
tests/fixtures/config/success-url/main.yaml vendored
View File

@@ -1,8 +0,0 @@
- tenant:
name: tenant-one
source:
gerrit:
config-projects:
- common-config
untrusted-projects:
- org/docs

2
tests/fixtures/layouts/timer-smtp.yaml vendored
View File

@@ -17,12 +17,10 @@
- job:
name: project-bitrot-stable-old
success-url: http://logs.example.com/{job.name}/{build.number}
run: playbooks/project-bitrot-stable-old.yaml
- job:
name: project-bitrot-stable-older
success-url: http://logs.example.com/{job.name}/{build.number}
run: playbooks/project-bitrot-stable-older.yaml
- project: