Fix quickstart example/test for Gerrit 3.12

This matches our intended/expected behavior for the Code-Review
label.

Change-Id: I9fb4e634b468f5774c012cb76e37458ffb5694ae
This commit is contained in:
James E. Blair
2025-05-20 11:09:52 -07:00
parent 2b6de82da3
commit 21cbe2610a

View File

@@ -59,7 +59,7 @@
createSignedTag = group Administrators
createSignedTag = group Project Owners
[label "Code-Review"]
function = MaxWithBlock
function = NoBlock
defaultValue = 0
value = -2 This shall not be merged
value = -1 I would prefer this is not merged as is
@@ -68,18 +68,20 @@
value = +2 Looks good to me, approved
copyCondition = changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN
[label "Verified"]
function = NoBlock
defaultValue = 0
value = -2 Fails
value = -1 Does not seem to work
value = 0 No score
value = +1 Works for me
value = +2 Verified
defaultValue = 0
copyCondition = changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE
[label "Workflow"]
function = NoBlock
defaultValue = 0
value = -1 Work in progress
value = 0 Ready for reviews
value = +1 Approved
defaultValue = 0
[submit-requirement "Verified"]
description = A maximum vote is required for the \
'Verified' label. A minimum vote is blocking.
@@ -90,3 +92,8 @@
'Workflow' label. A minimum vote is blocking.
submittableIf = label:Workflow=MAX AND -label:Workflow=MIN
canOverrideInChildProjects = true
[submit-requirement "Code-Review"]
description = A maximum vote is required for the \
'Code-Review' label. A minimum vote is blocking.
submittableIf = label:Code-Review=MAX AND -label:Code-Review=MIN
canOverrideInChildProjects = true