Update patch set 1

Patch Set 1:

(1 comment)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 20676 \u003c20676@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Tristan Cacqueray replied on the change"}
This commit is contained in:
Gerrit User 9311 2022-05-16 14:21:32 +00:00 committed by Gerrit Code Review
parent bfc30eaac3
commit 24408f6337
1 changed files with 17 additions and 0 deletions

View File

@ -50,6 +50,23 @@
"message": "\u003e Patch Set 1:\n\u003e \n\u003e We similarly discovered that network interface interrogation in the Ansible stdlib relies on the netaddr package, but doesn\u0027t declare a dependency on it (hence why it got appended to the list recently). Dropping ARA caused a regression for a bunch of jobs in OpenDev (and likely elsewhere) because ARA declared a dependency on netaddr and so was implicitly providing it in the venv.\n\u003e \n\u003e This raises a larger question, should Ansible be delcaring dependencies on modules used by its stdlib?\n\nCreated an issue in Ansible project: https://github.com/ansible/ansible/issues/77808",
"revId": "66844797d21da391447ec80731381649b45cb69e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3881f1e0_145d85ee",
"filename": "zuul/lib/ansible-config.conf",
"patchSetId": 1
},
"lineNbr": 4,
"author": {
"id": 9311
},
"writtenOn": "2022-05-16T14:21:32Z",
"side": 1,
"message": "Perhaps add the ansible issue reference here",
"revId": "66844797d21da391447ec80731381649b45cb69e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}