zuul
/
zuul
Code Issues Proposed changes

Ansible launcher: don't close stdout in command module 

If the job fails to close stdout/stderr, then this will cause
an exception.

Change-Id: I994c0a0c09bf2ec316ee7c7c51a18fa22372f152
This commit is contained in:
James E. Blair 2016-10-19 22:25:21 -07:00
parent fa3df0bf1f
commit 280cd8d062
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
zuul/ansible/library/command.py
View File

@ -323,7 +323,10 @@ def zuul_run_command(self, args, check_rc=False, close_fds=True, executable=None
"after child exited")
console.addLine("[Zuul] Task exit code: %s\n" % ret)
cmd.stdout.close()
# ZUUL: If the console log follow thread *is* stuck in readline,
# we can't close stdout (attempting to do so raises an
# exception) , so this is disabled.
# cmd.stdout.close()
# ZUUL: stdout and stderr are in the console log file
stdout = ''