zuul
/
zuul
Code Issues Proposed changes

Increase unit testing of host / group vars 

I noticed we were not actually checking the results of check-hostvars
job, so fix that. Also increase the coverage of using groups for
hosts.

Change-Id: I365c1d4070de94e3a8288a15dce4b4b8d038f994
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
This commit is contained in:
Paul Belanger 2018-04-06 13:22:29 -04:00 committed by James E. Blair
parent eb46b9c6d2
commit 2a67365a7c
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tests/fixtures/config/ansible/git/common-config/playbooks/check-hostvars.yaml vendored
View File

@ -24,3 +24,11 @@
- allvar == 'all'
- hostvar is not defined
- groupvar == 'group'
- hosts: group1
serial: 1
tasks:
- name: Assert groupvar is present.
assert:
that:
- groupvar == 'group'

3
tests/unit/test_v3.py
View File

@ -2067,6 +2067,9 @@ class TestAnsible(AnsibleZuulTestCase):
build_check_vars = self.getJobFromHistory('check-vars')
with self.jobLog(build_check_vars):
self.assertEqual(build_check_vars.result, 'SUCCESS')
build_check_hostvars = self.getJobFromHistory('check-hostvars')
with self.jobLog(build_check_hostvars):
self.assertEqual(build_check_hostvars.result, 'SUCCESS')
build_check_secret_names = self.getJobFromHistory('check-secret-names')
with self.jobLog(build_check_secret_names):
self.assertEqual(build_check_secret_names.result, 'SUCCESS')