zuul
/
zuul
Code Issues Proposed changes

Correct comments in requirement test cases 

The comments were misleading which led to a lot of head scratching. This
corrects the comments to reflect the realities of the test.

Change-Id: Id83243140558fb76e91f83843da8285fd17f384b
This commit is contained in:
Jesse Keating 2017-01-19 14:31:44 -08:00
parent 7f238a2991
commit 2dfc651202
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/test_requirements.py
View File

@ -248,7 +248,7 @@ class TestRequirementsVote2(ZuulTestCase):
self.assertEqual(len(self.history), 1)
self.assertEqual(self.history[0].name, job)
# A +2 should allow it to be enqueued
# A +2 from nobody should not cause it to be enqueued
B = self.fake_gerrit.addFakeChange(project, 'master', 'B')
# A comment event that we will keep submitting to trigger
comment = B.addApproval('code-review', 2, username='nobody')
@ -256,6 +256,7 @@ class TestRequirementsVote2(ZuulTestCase):
self.waitUntilSettled()
self.assertEqual(len(self.history), 1)
# A +2 from jenkins should allow it to be enqueued
B.addApproval('verified', 2, username='jenkins')
self.fake_gerrit.addEvent(comment)
self.waitUntilSettled()