From 4d263eb38c128386bddca97e42f1c944e3d50139 Mon Sep 17 00:00:00 2001 From: "James E. Blair" Date: Sun, 19 Feb 2017 15:13:39 -0800 Subject: [PATCH] Add note about pipelines and dynamic layouts After working with this system for a while, this TODO does not suggest to me anything that should be done, so convert it to a NOTE documenting why it is interesting. Change-Id: I8e50bc081f33a8efb3e9281c6460e4fb8e3bbd2e --- zuul/configloader.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/zuul/configloader.py b/zuul/configloader.py index 0b3d3dcca8..3f72520542 100644 --- a/zuul/configloader.py +++ b/zuul/configloader.py @@ -917,7 +917,12 @@ class ConfigLoader(object): files, False) layout = model.Layout() - # TODOv3(jeblair): copying the pipelines could be dangerous/confusing. + # NOTE: the actual pipeline objects (complete with queues and + # enqueued items) are copied by reference here. This allows + # our shadow dynamic configuration to continue to interact + # with all the other changes, each of which may have their own + # version of reality. We do not support creating, updating, + # or deleting pipelines in dynamic layout changes. layout.pipelines = tenant.layout.pipelines for config_job in config.jobs: