zuul
/
zuul
Code Issues Proposed changes

cli: prevent exception for the show command 

The cli doesn't have a columns arguments and the show command fail
with:
Traceback (most recent call last):
  File "zuul/cmd/client.py", line 205, in main
    if self.args.func():
  File "zuul/cmd/client.py", line 307, in show_running_jobs
    if self.args.columns.upper() == 'ALL':
AttributeError: 'Namespace' object has no attribute 'columns'

This change removes the columns filtering.

Change-Id: I99f940059882320865429dccd6ab24a670f6d51c
This commit is contained in:
Tristan Cacqueray 2019-06-10 09:38:01 +00:00
parent ed1d22bdca
commit 37195e3537
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
zuul/cmd/client.py
View File

@ -304,11 +304,7 @@ class Client(zuul.cmd.ZuulApp):
return True
all_fields = self._show_running_jobs_columns()
if self.args.columns.upper() == 'ALL':
fields = all_fields.keys()
else:
fields = [f.strip().lower() for f in self.args.columns.split(',')
if f.strip().lower() in all_fields]
fields = all_fields.keys()
table = prettytable.PrettyTable(
field_names=[all_fields[f]['title'] for f in fields])