zuul/zuul
Code Issues Proposed changes

Replace equals None with is None

Browse Source 
None is a singleton and should be tested for with is not ==.

Some people did a similar thing randomly on the master branch. It
just seems like a thing we should fix.

Change-Id: Iec0382e2c8812f0713699ab5a0cd3180086ad433
This commit is contained in:
Monty Taylor
2017-06-05 13:06:10 -05:00
parent 5996147c19
commit 38b553a0f6
3 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/unit/test_model.py
View File

@@ -106,7 +106,7 @@ class TestJob(BaseTestCase):
base.auth = model.AuthContext()
py27 = model.Job('py27')
self.assertEqual(None, py27.timeout)
self.assertIsNone(py27.timeout)
py27.inheritFrom(base)
self.assertEqual(30, py27.timeout)
self.assertEqual(['base-pre'],
@@ -115,7 +115,7 @@ class TestJob(BaseTestCase):
[x.path for x in py27.run])
self.assertEqual(['base-post'],
[x.path for x in py27.post_run])
self.assertEqual(None, py27.auth)
self.assertIsNone(py27.auth)
def test_job_variants(self):
# This simulates freezing a job.
@@ -433,11 +433,11 @@ class TestJob(BaseTestCase):
})
layout.addJob(in_repo_job_with_inherit_false)
self.assertEqual(None, in_repo_job_without_inherit.auth)
self.assertIsNone(in_repo_job_without_inherit.auth)
self.assertEqual(1, len(in_repo_job_with_inherit.auth.secrets))
self.assertEqual(in_repo_job_with_inherit.auth.secrets[0].name,
'pypi-credentials')
self.assertEqual(None, in_repo_job_with_inherit_false.auth)
self.assertIsNone(in_repo_job_with_inherit_false.auth)
def test_job_inheritance_job_tree(self):
tenant = model.Tenant('tenant')