From 3974eaf98711f7c0eed66d799924c845a5147545 Mon Sep 17 00:00:00 2001 From: Guillaume Chauvel Date: Wed, 10 Feb 2021 23:43:53 +0100 Subject: [PATCH] Gerrit: Add gerrit version check for HTTP review tag Review tags were added in gerrit starting from 2.13 https://gerrit-review.googlesource.com/c/gerrit/+/75803 On gerrit repository https://gerrit.googlesource.com/gerrit/ "git tag --contains c70e8625963297c6cee06c2c33e01af82b63d331" starts with tag 2.13 (no message in 2.13 release changelog) Change-Id: I685ecd71186ddacfb71ed6bf2db254540fa2abb4 --- zuul/driver/gerrit/gerritconnection.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/zuul/driver/gerrit/gerritconnection.py b/zuul/driver/gerrit/gerritconnection.py index 04c8a315e5..956f9d762f 100644 --- a/zuul/driver/gerrit/gerritconnection.py +++ b/zuul/driver/gerrit/gerritconnection.py @@ -1126,7 +1126,8 @@ class GerritConnection(BaseConnection): data['robot_comments'] = file_comments else: data['comments'] = file_comments - data['tag'] = 'autogenerated:zuul:%s' % (item.pipeline.name) + if self.version >= (2, 13, 0): + data['tag'] = 'autogenerated:zuul:%s' % (item.pipeline.name) changeid = "%s~%s~%s" % ( urllib.parse.quote(str(change.project), safe=''), urllib.parse.quote(str(change.branch), safe=''),