zuul
/
zuul
Code Issues Proposed changes

Merge "Remove unnecessary loop in github test" into feature/zuulv3

This commit is contained in:
Jenkins 2017-07-07 19:59:16 +00:00 committed by Gerrit Code Review
parent 56cc3b4817 3e78572327
commit 3b6156fd00
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tests/unit/test_github_requirements.py
View File

@ -240,13 +240,10 @@ class TestGithubRequirements(ZuulTestCase):
# The first negative review from derp should not cause it to be
# enqueued
for i in range(1, 4):
submitted_at = time.time() - 72 * 60 * 60
A.addReview('derp', 'CHANGES_REQUESTED',
submitted_at)
self.fake_github.emitEvent(comment)
self.waitUntilSettled()
self.assertEqual(len(self.history), 0)
A.addReview('derp', 'CHANGES_REQUESTED')
self.fake_github.emitEvent(comment)
self.waitUntilSettled()
self.assertEqual(len(self.history), 0)
# A positive review from derp should cause it to be enqueued
A.addReview('derp', 'APPROVED')