zuul
/
zuul
Code Issues Proposed changes

Update Github SHA cache on PR update 

It seems that the update of the SHA-to-PR cache in `getPull()` was
accidentally removed in Ib14bb387dbd233ff252cf57be7f0517770ade037.

This will lead to stale data in the cache and with that to events not
being processed, e.g. in case of an already resolved issue with multiple
PRs with the same HEAD SHA.

Change-Id: I178b63029d7a60523af4acefb3f05bff3daeb2c5
This commit is contained in:
Simon Westphahl 2021-08-05 10:08:37 +02:00
parent d87a9a8b8f
commit 3d9b9fa46b
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
zuul/driver/github/githubconnection.py
View File

@ -1626,6 +1626,9 @@ class GithubConnection(CachedBranchConnection):
labels = [l['name'] for l in pr['labels']]
pr['labels'] = labels
self._sha_pr_cache.update(project_name, pr)
log.debug('Got PR %s#%s', project_name, number)
return (pr, probj)