zuul/zuul
Code Issues Proposed changes

Default to 0o022 for python-daemon

Browse Source 
Ansible give us a warning about directories having world writeable,
this is due to python-daemon defaulting umask to 0.

  https://pagure.io/python-daemon/blob/master/f/daemon/daemon.py#_117

Switch to 0o022 for umask to disable world write for zuul directories.

Change-Id: I770652190f7c084d4232e06dab9390b346a05fbf
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
This commit is contained in:
Paul Belanger
2018-07-23 21:59:32 -04:00
parent 40a895b03c
commit 407f0c64cb
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
zuul/cmd/__init__.py
View File

@@ -194,7 +194,7 @@ class ZuulDaemonApp(ZuulApp, metaclass=abc.ABCMeta):
with pid:
pass
with daemon.DaemonContext(pidfile=pid):
with daemon.DaemonContext(pidfile=pid, umask=0o022):
self.run()
def send_command(self, cmd):