zuul
/
zuul
Code Issues Proposed changes

Fix AttributeError in executor client 

We were inadvertantly redifining the item variable which caused
this error:

  AttributeError: 'NoneType' object has no attribute 'project_configs'

If a parent item happened not to have a layout yet.

Change-Id: I78a30cc95a1fe30e6aca3c44faae048191af2cdd
This commit is contained in:
James E. Blair 2017-07-07 09:18:47 -07:00
parent 4bf2cc3448
commit 432f2ed4cd
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
zuul/executor/client.py
View File

@ -321,9 +321,9 @@ class ExecutorClient(object):
make_project_dict(project,
job_project.override_branch))
projects.add(project)
for item in all_items:
if item.change.project not in projects:
project = item.change.project
for i in all_items:
if i.change.project not in projects:
project = i.change.project
params['projects'].append(make_project_dict(project))
projects.add(project)