zuul
/
zuul
Code Issues Proposed changes

Merge "Fix null ref in github tests" into feature/zuulv3

This commit is contained in:
Jenkins 2017-08-03 22:17:07 +00:00 committed by Gerrit Code Review
parent b1439a554f b8203e4e89
commit 45ef1936e4
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/base.py
View File

@ -1001,7 +1001,7 @@ class FakeGithubConnection(githubconnection.GithubConnection):
def getPushEvent(self, project, ref, old_rev=None, new_rev=None,
added_files=[], removed_files=[], modified_files=[]):
if not old_rev:
old_rev = '00000000000000000000000000000000'
old_rev = '0' * 40
if not new_rev:
new_rev = random_sha1()
name = 'push'

4
tests/unit/test_github_driver.py
View File

@ -110,10 +110,8 @@ class TestGithubDriver(ZuulTestCase):
build_params = self.builds[0].parameters
self.assertEqual('refs/tags/newtag', build_params['zuul']['ref'])
self.assertEqual('00000000000000000000000000000000',
build_params['zuul']['oldrev'])
self.assertFalse('oldrev' in build_params['zuul'])
self.assertEqual(sha, build_params['zuul']['newrev'])
self.executor_server.hold_jobs_in_build = False
self.executor_server.release()
self.waitUntilSettled()