Add note about pipelines and dynamic layouts
After working with this system for a while, this TODO does not suggest to me anything that should be done, so convert it to a NOTE documenting why it is interesting. Change-Id: I8e50bc081f33a8efb3e9281c6460e4fb8e3bbd2e
This commit is contained in:
parent
1dc535eb6b
commit
4d263eb38c
|
@ -917,7 +917,12 @@ class ConfigLoader(object):
|
|||
files, False)
|
||||
|
||||
layout = model.Layout()
|
||||
# TODOv3(jeblair): copying the pipelines could be dangerous/confusing.
|
||||
# NOTE: the actual pipeline objects (complete with queues and
|
||||
# enqueued items) are copied by reference here. This allows
|
||||
# our shadow dynamic configuration to continue to interact
|
||||
# with all the other changes, each of which may have their own
|
||||
# version of reality. We do not support creating, updating,
|
||||
# or deleting pipelines in dynamic layout changes.
|
||||
layout.pipelines = tenant.layout.pipelines
|
||||
|
||||
for config_job in config.jobs:
|
||||
|
|
Loading…
Reference in New Issue