From 4d8325a3cc00839edd0a9858f5ece88981c19356 Mon Sep 17 00:00:00 2001 From: "James E. Blair" Date: Fri, 13 Sep 2019 09:54:50 -0700 Subject: [PATCH] Update gerrit pagination test fixtures These fixtures are missing the data returned by the "--current-patch-set" and "--commit-message" arguments, which we do pass when performing the queries. A future change alters where some of these data are parsed and will error because of this omission. This updates the data to match what is currently returned for these changes (with the old sortKeys manually added back in where appropriate). Change-Id: I11e983d22c4da818b3eeab1632ca7102aab087d5 --- tests/fixtures/gerrit/simple_query_pagination_new_1 | 6 +++--- tests/fixtures/gerrit/simple_query_pagination_new_2 | 4 ++-- tests/fixtures/gerrit/simple_query_pagination_old_1 | 6 +++--- tests/fixtures/gerrit/simple_query_pagination_old_2 | 4 ++-- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/tests/fixtures/gerrit/simple_query_pagination_new_1 b/tests/fixtures/gerrit/simple_query_pagination_new_1 index 873c3865a3..b152c2a40a 100644 --- a/tests/fixtures/gerrit/simple_query_pagination_new_1 +++ b/tests/fixtures/gerrit/simple_query_pagination_new_1 @@ -1,5 +1,5 @@ gerrit query --format json --commit-message --current-patch-set project:zuul/zuul -{"project":"zuul/zuul","branch":"master","topic":"(detached","id":"I173251c8b1569755124b7cb1a48b6274bf38c94b","number":"202867","subject":"Report the per-job build wait time to graphite","owner":{"name":"Timothy R. Chavez","email":"timothy.chavez@hp.com","username":"timrchavez"},"url":"https://review.openstack.org/202867","commitMessage":"Report the per-job build wait time to graphite\n\nKnowing how long a job waits to build in aggregate can give useful\ninsights into the performance and capacity of the build system. This\nchange also uses the node labels sent back from the gearman worker to\nsubmit metrics within that context.\n\nChange-Id: I173251c8b1569755124b7cb1a48b6274bf38c94b\nDepends-On: Ibca938fcf8a65facd7e39dab4eb994dfc637722a\n","createdOn":1437104683,"lastUpdated":1440760891,"open":true,"status":"NEW"} -{"project":"zuul/zuul","branch":"master","topic":"ignore-deletes","id":"Iea75d05ddcb49b0bf748b72b9d2d5472d077f0c6","number":"178833","subject":"Add option to ignore ref-updated events emitted by branch deletions","owner":{"name":"K Jonathan Harker","email":"code@gentlydownthe.net","username":"jesusaurus"},"url":"https://review.openstack.org/178833","commitMessage":"Add option to ignore ref-updated events emitted by branch deletions\n\nWhen a branch is deleted, gerrit emits a ref-updated event with a newrev\nvalue of all zeros. This adds a boolean field to optionally not trigger\non these ref-updated events.\n\nChange-Id: Iea75d05ddcb49b0bf748b72b9d2d5472d077f0c6\n","createdOn":1430339761,"lastUpdated":1440735750,"open":true,"status":"NEW"} -{"project":"zuul/zuul","branch":"master","topic":"undefined-projects","id":"I7912197fb86c1a7becb7f43ca36078101f632715","number":"207094","subject":"Dependencies from undefined projects","owner":{"name":"Evgeny Antyshev","email":"eantyshev@virtuozzo.com","username":"eantyshev"},"url":"https://review.openstack.org/207094","commitMessage":"Dependencies from undefined projects\n\n3rd party CI layout usually has only a few projects defined,\nso it\u0027s possible that some changes depend on projects\nwhich are unknown to Zuul scheduler.\nThese items had None as a \"item.change.project\", which\nis not handled in many places, for ex. in reconfiguration.\n\nThese cases could be handled by defining these projects in layout\nas \"foreign\" projects: no jobs, no other non-standard attributes.\nChanges to those projects are also dropped, unless\nthey came as dependencies.\n\nChange-Id: I7912197fb86c1a7becb7f43ca36078101f632715\n","createdOn":1438183395,"lastUpdated":1440667433,"open":true,"status":"NEW"} +{"project":"zuul/zuul","branch":"master","topic":"(detached","id":"I173251c8b1569755124b7cb1a48b6274bf38c94b","number":"202867","subject":"Report the per-job build wait time to graphite","owner":{"name":"Timothy R. Chavez","email":"timrchavez@us.ibm.com","username":"timrchavez"},"url":"https://review.opendev.org/202867","commitMessage":"Report the per-job build wait time to graphite\n\nKnowing how long a job waits to build in aggregate can give useful\ninsights into the performance and capacity of the build system. This\nchange also uses the node labels sent back from the gearman worker to\nsubmit metrics within that context.\n\nChange-Id: I173251c8b1569755124b7cb1a48b6274bf38c94b\nDepends-On: Ibca938fcf8a65facd7e39dab4eb994dfc637722a\n","createdOn":1437104683,"lastUpdated":1444156000,"open":false,"status":"MERGED","currentPatchSet":{"number":"11","revision":"b2332081d8e0fda780bbc1f4dfd917f2546d1724","parents":["f8e892567ce2109651e52f721e3887016fca8dbe"],"ref":"refs/changes/67/202867/11","uploader":{"name":"Timothy R. Chavez","email":"timrchavez@us.ibm.com","username":"timrchavez"},"createdOn":1440557629,"author":{"name":"Timothy R. Chavez","email":"timrchavez@us.ibm.com","username":"timrchavez"},"isDraft":false,"kind":"REWORK","approvals":[{"type":"Code-Review","description":"Code-Review","value":"2","grantedOn":1440667522,"by":{"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"}},{"type":"Code-Review","description":"Code-Review","value":"1","grantedOn":1441845935,"by":{"name":"Timothy R. Chavez","email":"timrchavez@us.ibm.com","username":"timrchavez"}},{"type":"Code-Review","description":"Code-Review","value":"2","grantedOn":1444067234,"by":{"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"}},{"type":"Code-Review","description":"Code-Review","value":"2","grantedOn":1444155658,"by":{"name":"Jeremy Stanley","email":"fungi@yuggoth.org","username":"fungi"}},{"type":"Workflow","description":"Workflow","value":"1","grantedOn":1444155658,"by":{"name":"Jeremy Stanley","email":"fungi@yuggoth.org","username":"fungi"}},{"type":"SUBM","value":"1","grantedOn":1444155999,"by":{"name":"Jenkins","username":"jenkins"}},{"type":"Verified","description":"Verified","value":"2","grantedOn":1444155999,"by":{"name":"Jenkins","username":"jenkins"}}],"sizeInsertions":39,"sizeDeletions":-5}} +{"project":"zuul/zuul","branch":"master","topic":"ignore-deletes","id":"Iea75d05ddcb49b0bf748b72b9d2d5472d077f0c6","number":"178833","subject":"Add option to ignore ref-updated events emitted by branch deletions","owner":{"name":"K Jonathan Harker","email":"code@gentlydownthe.net","username":"jesusaurus"},"url":"https://review.opendev.org/178833","commitMessage":"Add option to ignore ref-updated events emitted by branch deletions\n\nWhen a branch is deleted, gerrit emits a ref-updated event with a newrev\nvalue of all zeros. This adds a boolean field to optionally not trigger\non these ref-updated events.\n\nChange-Id: Iea75d05ddcb49b0bf748b72b9d2d5472d077f0c6\n","createdOn":1430339761,"lastUpdated":1447569360,"open":false,"status":"MERGED","currentPatchSet":{"number":"12","revision":"f95e7232acacab4560390e66af3747e4b5984112","parents":["135a9358c18a1a1fdc26952865622d2b9add1011"],"ref":"refs/changes/33/178833/12","uploader":{"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"createdOn":1447522235,"author":{"name":"K Jonathan Harker","email":"code@gentlydownthe.net","username":"jesusaurus"},"isDraft":false,"kind":"REWORK","approvals":[{"type":"Code-Review","description":"Code-Review","value":"2","grantedOn":1447522288,"by":{"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"}},{"type":"Code-Review","description":"Code-Review","value":"2","grantedOn":1447569000,"by":{"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"}},{"type":"Workflow","description":"Workflow","value":"1","grantedOn":1447569000,"by":{"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"}},{"type":"Verified","description":"Verified","value":"2","grantedOn":1447569358,"by":{"name":"Jenkins","username":"jenkins"}},{"type":"SUBM","value":"1","grantedOn":1447569359,"by":{"name":"Jenkins","username":"jenkins"}}],"sizeInsertions":87,"sizeDeletions":-2}} +{"project":"zuul/zuul","branch":"master","topic":"undefined-projects","id":"I7912197fb86c1a7becb7f43ca36078101f632715","number":"207094","subject":"Dependencies from undefined projects","owner":{"name":"Evgeny Antyshev","email":"eantyshev@gmail.com","username":"eantyshev"},"url":"https://review.opendev.org/207094","commitMessage":"Dependencies from undefined projects\n\n3rd party CI layout usually has only a few projects defined,\nso it\u0027s possible that some changes depend on projects\nwhich are unknown to Zuul scheduler.\nThese items had None as a \"item.change.project\", which\nis not handled in many places, for ex. in reconfiguration.\n\nThese cases could be handled by defining these projects in layout\nas \"foreign\" projects: no jobs, no other non-standard attributes.\nChanges to those projects are also dropped, unless\nthey came as dependencies.\n\nChange-Id: I7912197fb86c1a7becb7f43ca36078101f632715\n","createdOn":1438183395,"lastUpdated":1446492606,"open":false,"status":"MERGED","currentPatchSet":{"number":"9","revision":"0deaaadac7143692961b9d28abee8cea570ff3ce","parents":["e8aa3c6842501358a60908f93b3c6b41fc69e5d0"],"ref":"refs/changes/94/207094/9","uploader":{"name":"Evgeny Antyshev","email":"eantyshev@gmail.com","username":"eantyshev"},"createdOn":1443109665,"author":{"name":"Evgeny Antyshev","email":"eantyshev@gmail.com","username":"eantyshev"},"isDraft":false,"kind":"REWORK","approvals":[{"type":"Code-Review","description":"Code-Review","value":"2","grantedOn":1443705972,"by":{"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"}},{"type":"Code-Review","description":"Code-Review","value":"2","grantedOn":1444132693,"by":{"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"}},{"type":"Code-Review","description":"Code-Review","value":"1","grantedOn":1444665916,"by":{"name":"Lenny Verkhovsky","email":"lennyb@mellanox.com","username":"lennyb"}},{"type":"Code-Review","description":"Code-Review","value":"1","grantedOn":1444749407,"by":{"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"}},{"type":"Code-Review","description":"Code-Review","value":"2","grantedOn":1446492363,"by":{"name":"James E. Blair","email":"corvus@inaugust.com","username":"corvus"}},{"type":"Workflow","description":"Workflow","value":"1","grantedOn":1446492363,"by":{"name":"James E. Blair","email":"corvus@inaugust.com","username":"corvus"}},{"type":"SUBM","value":"1","grantedOn":1446492605,"by":{"name":"Jenkins","username":"jenkins"}},{"type":"Verified","description":"Verified","value":"2","grantedOn":1446492605,"by":{"name":"Jenkins","username":"jenkins"}}],"sizeInsertions":156,"sizeDeletions":-18}} {"type":"stats","rowCount":3,"runTimeMilliseconds":12,"moreChanges":true} diff --git a/tests/fixtures/gerrit/simple_query_pagination_new_2 b/tests/fixtures/gerrit/simple_query_pagination_new_2 index 2d1c472142..8a2dea2c0f 100644 --- a/tests/fixtures/gerrit/simple_query_pagination_new_2 +++ b/tests/fixtures/gerrit/simple_query_pagination_new_2 @@ -1,4 +1,4 @@ gerrit query --format json --commit-message --current-patch-set project:zuul/zuul -S 3 -{"project":"zuul/zuul","branch":"master","topic":"github-integration","id":"I95f41088ea160d4e33a507c4a413e3fa7f08906b","number":"192457","subject":"(WIP) Fix job hierarchy bug.","owner":{"name":"Wayne Warren","email":"waynr+launchpad@sdf.org","username":"waynr"},"url":"https://review.openstack.org/192457","commitMessage":"(WIP) Fix job hierarchy bug.\n\nJobTree.addJob may return \u0027None\u0027, this prevents that from happening.\n\nChange-Id: I95f41088ea160d4e33a507c4a413e3fa7f08906b\n","createdOn":1434498278,"lastUpdated":1440608984,"sortKey":"003763050002efc9","open":true,"status":"NEW"} -{"project":"zuul/zuul","branch":"master","topic":"github-integration","id":"Ic5887d00ff302f67469df5154e9df10b99f1cfcd","number":"215642","subject":"(WIP) Allow using webapp from connections","owner":{"name":"Jan Hruban","email":"jan.hruban@gooddata.com","username":"hrubi"},"url":"https://review.openstack.org/215642","commitMessage":"(WIP) Allow using webapp from connections\n\nAllow connections to register their own handlers for HTTP URIs inside\nthe zuul\u0027s webapp HTTP server. That way, connections can listen for\nevents comming through HTTP.\n\nChange-Id: Ic5887d00ff302f67469df5154e9df10b99f1cfcd\n","createdOn":1440165019,"lastUpdated":1440602591,"sortKey":"0037629b00034a5a","open":true,"status":"NEW"} +{"project":"zuul/zuul","branch":"master","topic":"github-integration","id":"I95f41088ea160d4e33a507c4a413e3fa7f08906b","number":"192457","subject":"Fix job hierarchy bug.","owner":{"name":"Wayne Warren","email":"wayne.warren.s@gmail.com","username":"waynr"},"url":"https://review.opendev.org/192457","commitMessage":"Fix job hierarchy bug.\n\nJobTree.addJob may return \u0027None\u0027, this prevents that from happening.\n\nChange-Id: I95f41088ea160d4e33a507c4a413e3fa7f08906b\n","createdOn":1434498278,"lastUpdated":1516314837,"open":false,"status":"ABANDONED","currentPatchSet":{"number":"40","revision":"938c114a5225c358d4bbedb71f3c555435d12145","parents":["7b2bd708651e54b7bfa70d2a2130ffa3a4ce9d52"],"ref":"refs/changes/57/192457/40","uploader":{"name":"Jan Hruban","email":"jan.hruban@gooddata.com","username":"hrubi"},"createdOn":1483452876,"author":{"name":"Wayne","email":"wayne@puppetlabs.com","username":""},"isDraft":false,"kind":"TRIVIAL_REBASE","sizeInsertions":6,"sizeDeletions":-2}} +{"project":"zuul/zuul","branch":"master","topic":"github-integration","id":"Ic5887d00ff302f67469df5154e9df10b99f1cfcd","number":"215642","subject":"Allow using webapp from connections","owner":{"name":"Jan Hruban","email":"jan.hruban@gooddata.com","username":"hrubi"},"url":"https://review.opendev.org/215642","commitMessage":"Allow using webapp from connections\n\nAllow connections to register their own handlers for HTTP URIs inside\nthe zuul\u0027s webapp HTTP server. That way, connections can listen for\nevents comming through HTTP.\n\nChange-Id: Ic5887d00ff302f67469df5154e9df10b99f1cfcd\n","createdOn":1440165019,"lastUpdated":1516314852,"open":false,"status":"ABANDONED","currentPatchSet":{"number":"26","revision":"8daec1149cd78c2d6451864669c1c663afddc26f","parents":["38ce39fe5808810a5b3ea6fb4ce0d951757977f1"],"ref":"refs/changes/42/215642/26","uploader":{"name":"Jan Hruban","email":"jan.hruban@gooddata.com","username":"hrubi"},"createdOn":1478782904,"author":{"name":"Jan Hruban","email":"jan.hruban@gooddata.com","username":"hrubi"},"isDraft":false,"kind":"REWORK","approvals":[{"type":"Verified","description":"Verified","value":"1","grantedOn":1478783398,"by":{"name":"Jenkins","username":"jenkins"}}],"sizeInsertions":80,"sizeDeletions":-27}} {"type":"stats","rowCount":2,"runTimeMilliseconds":12,"moreChanges":false} diff --git a/tests/fixtures/gerrit/simple_query_pagination_old_1 b/tests/fixtures/gerrit/simple_query_pagination_old_1 index 391f1249e3..8ae209028b 100644 --- a/tests/fixtures/gerrit/simple_query_pagination_old_1 +++ b/tests/fixtures/gerrit/simple_query_pagination_old_1 @@ -1,5 +1,5 @@ gerrit query --format json --commit-message --current-patch-set project:zuul/zuul -{"project":"zuul/zuul","branch":"master","topic":"(detached","id":"I173251c8b1569755124b7cb1a48b6274bf38c94b","number":"202867","subject":"Report the per-job build wait time to graphite","owner":{"name":"Timothy R. Chavez","email":"timothy.chavez@hp.com","username":"timrchavez"},"url":"https://review.openstack.org/202867","commitMessage":"Report the per-job build wait time to graphite\n\nKnowing how long a job waits to build in aggregate can give useful\ninsights into the performance and capacity of the build system. This\nchange also uses the node labels sent back from the gearman worker to\nsubmit metrics within that context.\n\nChange-Id: I173251c8b1569755124b7cb1a48b6274bf38c94b\nDepends-On: Ibca938fcf8a65facd7e39dab4eb994dfc637722a\n","createdOn":1437104683,"lastUpdated":1440760891,"sortKey":"00376ce900031873","open":true,"status":"NEW"} -{"project":"zuul/zuul","branch":"master","topic":"ignore-deletes","id":"Iea75d05ddcb49b0bf748b72b9d2d5472d077f0c6","number":"178833","subject":"Add option to ignore ref-updated events emitted by branch deletions","owner":{"name":"K Jonathan Harker","email":"code@gentlydownthe.net","username":"jesusaurus"},"url":"https://review.openstack.org/178833","commitMessage":"Add option to ignore ref-updated events emitted by branch deletions\n\nWhen a branch is deleted, gerrit emits a ref-updated event with a newrev\nvalue of all zeros. This adds a boolean field to optionally not trigger\non these ref-updated events.\n\nChange-Id: Iea75d05ddcb49b0bf748b72b9d2d5472d077f0c6\n","createdOn":1430339761,"lastUpdated":1440735750,"sortKey":"00376b460002ba91","open":true,"status":"NEW"} -{"project":"zuul/zuul","branch":"master","topic":"undefined-projects","id":"I7912197fb86c1a7becb7f43ca36078101f632715","number":"207094","subject":"Dependencies from undefined projects","owner":{"name":"Evgeny Antyshev","email":"eantyshev@virtuozzo.com","username":"eantyshev"},"url":"https://review.openstack.org/207094","commitMessage":"Dependencies from undefined projects\n\n3rd party CI layout usually has only a few projects defined,\nso it\u0027s possible that some changes depend on projects\nwhich are unknown to Zuul scheduler.\nThese items had None as a \"item.change.project\", which\nis not handled in many places, for ex. in reconfiguration.\n\nThese cases could be handled by defining these projects in layout\nas \"foreign\" projects: no jobs, no other non-standard attributes.\nChanges to those projects are also dropped, unless\nthey came as dependencies.\n\nChange-Id: I7912197fb86c1a7becb7f43ca36078101f632715\n","createdOn":1438183395,"lastUpdated":1440667433,"sortKey":"003766d3000328f6","open":true,"status":"NEW"} +{"project":"zuul/zuul","branch":"master","topic":"(detached","id":"I173251c8b1569755124b7cb1a48b6274bf38c94b","number":"202867","subject":"Report the per-job build wait time to graphite","owner":{"name":"Timothy R. Chavez","email":"timrchavez@us.ibm.com","username":"timrchavez"},"url":"https://review.opendev.org/202867","commitMessage":"Report the per-job build wait time to graphite\n\nKnowing how long a job waits to build in aggregate can give useful\ninsights into the performance and capacity of the build system. This\nchange also uses the node labels sent back from the gearman worker to\nsubmit metrics within that context.\n\nChange-Id: I173251c8b1569755124b7cb1a48b6274bf38c94b\nDepends-On: Ibca938fcf8a65facd7e39dab4eb994dfc637722a\n","createdOn":1437104683,"lastUpdated":1444156000,"open":false,"status":"MERGED","currentPatchSet":{"number":"11","revision":"b2332081d8e0fda780bbc1f4dfd917f2546d1724","parents":["f8e892567ce2109651e52f721e3887016fca8dbe"],"ref":"refs/changes/67/202867/11","uploader":{"name":"Timothy R. Chavez","email":"timrchavez@us.ibm.com","username":"timrchavez"},"createdOn":1440557629,"author":{"name":"Timothy R. Chavez","email":"timrchavez@us.ibm.com","username":"timrchavez"},"isDraft":false,"kind":"REWORK","approvals":[{"type":"Code-Review","description":"Code-Review","value":"2","grantedOn":1440667522,"by":{"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"}},{"type":"Code-Review","description":"Code-Review","value":"1","grantedOn":1441845935,"by":{"name":"Timothy R. Chavez","email":"timrchavez@us.ibm.com","username":"timrchavez"}},{"type":"Code-Review","description":"Code-Review","value":"2","grantedOn":1444067234,"by":{"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"}},{"type":"Code-Review","description":"Code-Review","value":"2","grantedOn":1444155658,"by":{"name":"Jeremy Stanley","email":"fungi@yuggoth.org","username":"fungi"}},{"type":"Workflow","description":"Workflow","value":"1","grantedOn":1444155658,"by":{"name":"Jeremy Stanley","email":"fungi@yuggoth.org","username":"fungi"}},{"type":"SUBM","value":"1","grantedOn":1444155999,"by":{"name":"Jenkins","username":"jenkins"}},{"type":"Verified","description":"Verified","value":"2","grantedOn":1444155999,"by":{"name":"Jenkins","username":"jenkins"}}],"sizeInsertions":39,"sizeDeletions":-5},"sortKey":"00376ce900031873"} +{"project":"zuul/zuul","branch":"master","topic":"ignore-deletes","id":"Iea75d05ddcb49b0bf748b72b9d2d5472d077f0c6","number":"178833","subject":"Add option to ignore ref-updated events emitted by branch deletions","owner":{"name":"K Jonathan Harker","email":"code@gentlydownthe.net","username":"jesusaurus"},"url":"https://review.opendev.org/178833","commitMessage":"Add option to ignore ref-updated events emitted by branch deletions\n\nWhen a branch is deleted, gerrit emits a ref-updated event with a newrev\nvalue of all zeros. This adds a boolean field to optionally not trigger\non these ref-updated events.\n\nChange-Id: Iea75d05ddcb49b0bf748b72b9d2d5472d077f0c6\n","createdOn":1430339761,"lastUpdated":1447569360,"open":false,"status":"MERGED","currentPatchSet":{"number":"12","revision":"f95e7232acacab4560390e66af3747e4b5984112","parents":["135a9358c18a1a1fdc26952865622d2b9add1011"],"ref":"refs/changes/33/178833/12","uploader":{"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"createdOn":1447522235,"author":{"name":"K Jonathan Harker","email":"code@gentlydownthe.net","username":"jesusaurus"},"isDraft":false,"kind":"REWORK","approvals":[{"type":"Code-Review","description":"Code-Review","value":"2","grantedOn":1447522288,"by":{"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"}},{"type":"Code-Review","description":"Code-Review","value":"2","grantedOn":1447569000,"by":{"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"}},{"type":"Workflow","description":"Workflow","value":"1","grantedOn":1447569000,"by":{"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"}},{"type":"Verified","description":"Verified","value":"2","grantedOn":1447569358,"by":{"name":"Jenkins","username":"jenkins"}},{"type":"SUBM","value":"1","grantedOn":1447569359,"by":{"name":"Jenkins","username":"jenkins"}}],"sizeInsertions":87,"sizeDeletions":-2},"sortKey":"00376b460002ba91"} +{"project":"zuul/zuul","branch":"master","topic":"undefined-projects","id":"I7912197fb86c1a7becb7f43ca36078101f632715","number":"207094","subject":"Dependencies from undefined projects","owner":{"name":"Evgeny Antyshev","email":"eantyshev@gmail.com","username":"eantyshev"},"url":"https://review.opendev.org/207094","commitMessage":"Dependencies from undefined projects\n\n3rd party CI layout usually has only a few projects defined,\nso it\u0027s possible that some changes depend on projects\nwhich are unknown to Zuul scheduler.\nThese items had None as a \"item.change.project\", which\nis not handled in many places, for ex. in reconfiguration.\n\nThese cases could be handled by defining these projects in layout\nas \"foreign\" projects: no jobs, no other non-standard attributes.\nChanges to those projects are also dropped, unless\nthey came as dependencies.\n\nChange-Id: I7912197fb86c1a7becb7f43ca36078101f632715\n","createdOn":1438183395,"lastUpdated":1446492606,"open":false,"status":"MERGED","currentPatchSet":{"number":"9","revision":"0deaaadac7143692961b9d28abee8cea570ff3ce","parents":["e8aa3c6842501358a60908f93b3c6b41fc69e5d0"],"ref":"refs/changes/94/207094/9","uploader":{"name":"Evgeny Antyshev","email":"eantyshev@gmail.com","username":"eantyshev"},"createdOn":1443109665,"author":{"name":"Evgeny Antyshev","email":"eantyshev@gmail.com","username":"eantyshev"},"isDraft":false,"kind":"REWORK","approvals":[{"type":"Code-Review","description":"Code-Review","value":"2","grantedOn":1443705972,"by":{"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"}},{"type":"Code-Review","description":"Code-Review","value":"2","grantedOn":1444132693,"by":{"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"}},{"type":"Code-Review","description":"Code-Review","value":"1","grantedOn":1444665916,"by":{"name":"Lenny Verkhovsky","email":"lennyb@mellanox.com","username":"lennyb"}},{"type":"Code-Review","description":"Code-Review","value":"1","grantedOn":1444749407,"by":{"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"}},{"type":"Code-Review","description":"Code-Review","value":"2","grantedOn":1446492363,"by":{"name":"James E. Blair","email":"corvus@inaugust.com","username":"corvus"}},{"type":"Workflow","description":"Workflow","value":"1","grantedOn":1446492363,"by":{"name":"James E. Blair","email":"corvus@inaugust.com","username":"corvus"}},{"type":"SUBM","value":"1","grantedOn":1446492605,"by":{"name":"Jenkins","username":"jenkins"}},{"type":"Verified","description":"Verified","value":"2","grantedOn":1446492605,"by":{"name":"Jenkins","username":"jenkins"}}],"sizeInsertions":156,"sizeDeletions":-18},"sortKey":"003766d3000328f6"} {"type":"stats","rowCount":3,"runTimeMilliseconds":12} diff --git a/tests/fixtures/gerrit/simple_query_pagination_old_2 b/tests/fixtures/gerrit/simple_query_pagination_old_2 index 9099a874b6..f0ba1eb88b 100644 --- a/tests/fixtures/gerrit/simple_query_pagination_old_2 +++ b/tests/fixtures/gerrit/simple_query_pagination_old_2 @@ -1,4 +1,4 @@ gerrit query --format json --commit-message --current-patch-set project:zuul/zuul resume_sortkey:'003766d3000328f6' -{"project":"zuul/zuul","branch":"master","topic":"github-integration","id":"I95f41088ea160d4e33a507c4a413e3fa7f08906b","number":"192457","subject":"(WIP) Fix job hierarchy bug.","owner":{"name":"Wayne Warren","email":"waynr+launchpad@sdf.org","username":"waynr"},"url":"https://review.openstack.org/192457","commitMessage":"(WIP) Fix job hierarchy bug.\n\nJobTree.addJob may return \u0027None\u0027, this prevents that from happening.\n\nChange-Id: I95f41088ea160d4e33a507c4a413e3fa7f08906b\n","createdOn":1434498278,"lastUpdated":1440608984,"sortKey":"003763050002efc9","open":true,"status":"NEW"} -{"project":"zuul/zuul","branch":"master","topic":"github-integration","id":"Ic5887d00ff302f67469df5154e9df10b99f1cfcd","number":"215642","subject":"(WIP) Allow using webapp from connections","owner":{"name":"Jan Hruban","email":"jan.hruban@gooddata.com","username":"hrubi"},"url":"https://review.openstack.org/215642","commitMessage":"(WIP) Allow using webapp from connections\n\nAllow connections to register their own handlers for HTTP URIs inside\nthe zuul\u0027s webapp HTTP server. That way, connections can listen for\nevents comming through HTTP.\n\nChange-Id: Ic5887d00ff302f67469df5154e9df10b99f1cfcd\n","createdOn":1440165019,"lastUpdated":1440602591,"sortKey":"0037629b00034a5a","open":true,"status":"NEW"} +{"project":"zuul/zuul","branch":"master","topic":"github-integration","id":"I95f41088ea160d4e33a507c4a413e3fa7f08906b","number":"192457","subject":"Fix job hierarchy bug.","owner":{"name":"Wayne Warren","email":"wayne.warren.s@gmail.com","username":"waynr"},"url":"https://review.opendev.org/192457","commitMessage":"Fix job hierarchy bug.\n\nJobTree.addJob may return \u0027None\u0027, this prevents that from happening.\n\nChange-Id: I95f41088ea160d4e33a507c4a413e3fa7f08906b\n","createdOn":1434498278,"lastUpdated":1516314837,"open":false,"status":"ABANDONED","currentPatchSet":{"number":"40","revision":"938c114a5225c358d4bbedb71f3c555435d12145","parents":["7b2bd708651e54b7bfa70d2a2130ffa3a4ce9d52"],"ref":"refs/changes/57/192457/40","uploader":{"name":"Jan Hruban","email":"jan.hruban@gooddata.com","username":"hrubi"},"createdOn":1483452876,"author":{"name":"Wayne","email":"wayne@puppetlabs.com","username":""},"isDraft":false,"kind":"TRIVIAL_REBASE","sizeInsertions":6,"sizeDeletions":-2},"sortKey":"003763050002efc9"} +{"project":"zuul/zuul","branch":"master","topic":"github-integration","id":"Ic5887d00ff302f67469df5154e9df10b99f1cfcd","number":"215642","subject":"Allow using webapp from connections","owner":{"name":"Jan Hruban","email":"jan.hruban@gooddata.com","username":"hrubi"},"url":"https://review.opendev.org/215642","commitMessage":"Allow using webapp from connections\n\nAllow connections to register their own handlers for HTTP URIs inside\nthe zuul\u0027s webapp HTTP server. That way, connections can listen for\nevents comming through HTTP.\n\nChange-Id: Ic5887d00ff302f67469df5154e9df10b99f1cfcd\n","createdOn":1440165019,"lastUpdated":1516314852,"open":false,"status":"ABANDONED","currentPatchSet":{"number":"26","revision":"8daec1149cd78c2d6451864669c1c663afddc26f","parents":["38ce39fe5808810a5b3ea6fb4ce0d951757977f1"],"ref":"refs/changes/42/215642/26","uploader":{"name":"Jan Hruban","email":"jan.hruban@gooddata.com","username":"hrubi"},"createdOn":1478782904,"author":{"name":"Jan Hruban","email":"jan.hruban@gooddata.com","username":"hrubi"},"isDraft":false,"kind":"REWORK","approvals":[{"type":"Verified","description":"Verified","value":"1","grantedOn":1478783398,"by":{"name":"Jenkins","username":"jenkins"}}],"sizeInsertions":80,"sizeDeletions":-27},"sortKey":"0037629b00034a5a"} {"type":"stats","rowCount":2,"runTimeMilliseconds":12}