From 5a85bb05fd077d714b73a2d6b77211f264770ee6 Mon Sep 17 00:00:00 2001 From: Gerrit User 9311 <9311@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Thu, 2 May 2024 19:33:37 +0000 Subject: [PATCH] Update patch set 5 Patch Set 5: Code-Review+2 (2 comments) Patch-set: 5 Label: Code-Review=+2, 7aae1c368e7eab09f14d2a6847fcd6bbfa35bf4a --- 5ac02b0f2bc80df6f530a4ccb9e6b56254867f8f | 41 ++++++++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/5ac02b0f2bc80df6f530a4ccb9e6b56254867f8f b/5ac02b0f2bc80df6f530a4ccb9e6b56254867f8f index 338af76ac6..fdefd9f710 100644 --- a/5ac02b0f2bc80df6f530a4ccb9e6b56254867f8f +++ b/5ac02b0f2bc80df6f530a4ccb9e6b56254867f8f @@ -17,6 +17,23 @@ "revId": "5ac02b0f2bc80df6f530a4ccb9e6b56254867f8f", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": false, + "key": { + "uuid": "c77ded00_7a67904d", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 5 + }, + "lineNbr": 0, + "author": { + "id": 9311 + }, + "writtenOn": "2024-05-02T19:33:37Z", + "side": 1, + "message": "Removing my -1 since we can view that stack as all-or-nothing.", + "revId": "5ac02b0f2bc80df6f530a4ccb9e6b56254867f8f", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": { @@ -40,6 +57,30 @@ "revId": "5ac02b0f2bc80df6f530a4ccb9e6b56254867f8f", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": true, + "key": { + "uuid": "5e2ac16a_ba6677b6", + "filename": "web/src/containers/status/PipelineSummary.jsx", + "patchSetId": 5 + }, + "lineNbr": 56, + "author": { + "id": 9311 + }, + "writtenOn": "2024-05-02T19:33:37Z", + "side": 1, + "message": "I meant, I think it would help if this check was implemented as a `isPipelineDependent` predicate function.", + "parentUuid": "6acaad4f_d5369488", + "range": { + "startLine": 56, + "startChar": 44, + "endLine": 56, + "endChar": 46 + }, + "revId": "5ac02b0f2bc80df6f530a4ccb9e6b56254867f8f", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": {