From 5ec14aa8cb3639ed4a5afa7a66e7f832a8988064 Mon Sep 17 00:00:00 2001 From: "James E. Blair" Date: Fri, 10 Aug 2018 15:41:21 -0700 Subject: [PATCH] Fix race in test_crd_check_unknown The Gerrit change depends on a GitHub change which hasn't finished propogating by the time the Gerrit event was received. Wait until things have settled after the GitHub change is created. Change-Id: I0750c9992f35cf52278cf24562802f7fc4ef0319 --- tests/unit/test_cross_crd.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/unit/test_cross_crd.py b/tests/unit/test_cross_crd.py index 20b2702c46..74e64a6894 100644 --- a/tests/unit/test_cross_crd.py +++ b/tests/unit/test_cross_crd.py @@ -280,6 +280,7 @@ class TestGerritToGithubCRD(ZuulTestCase): A = self.fake_gerrit.addFakeChange('gerrit/project1', 'master', 'A') B = self.fake_github.openFakePullRequest( 'github/project2', 'master', 'B') + self.waitUntilSettled() # A Depends-On: B A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (