Update patch set 2

Patch Set 2:

(3 comments)

Patch-set: 2
CC: Gerrit User 4146 <4146@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 1 \u003c1@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Clark Boylan replied on the change"}
This commit is contained in:
Gerrit User 4146 2022-05-16 23:05:38 +00:00 committed by Gerrit Code Review
parent e1d58e6615
commit 62adf97d4b
1 changed files with 61 additions and 0 deletions

View File

@ -0,0 +1,61 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "a450e7e0_4f271892",
"filename": "doc/source/tenants.rst",
"patchSetId": 2
},
"lineNbr": 246,
"author": {
"id": 4146
},
"writtenOn": "2022-05-16T23:05:38Z",
"side": 1,
"message": "This statement seems to be in conflict with the statement at line 238-239 and line 259-261? I\u0027m not sure what it means to not load any in repo config for a branch but then also treat it as if every change updates config dynamically. Aren\u0027t dynamic config updates the updates from in repo config change?\n\nThe release note seems to distinguish between static and dynamic which seems to be a bit more accurate?",
"range": {
"startLine": 245,
"startChar": 47,
"endLine": 246,
"endChar": 60
},
"revId": "46fe62abc0d74925dc1c513838cc2aaf5e7c319a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "498e65e0_df5fbd42",
"filename": "tests/fixtures/config/dynamic-only-project/git/common-config/zuul.yaml",
"patchSetId": 2
},
"lineNbr": 47,
"author": {
"id": 4146
},
"writtenOn": "2022-05-16T23:05:38Z",
"side": 1,
"message": "The test projects don\u0027t seem to configure periodic jobs. Can this be removed?",
"revId": "46fe62abc0d74925dc1c513838cc2aaf5e7c319a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "6b75cb2e_69a6b497",
"filename": "tests/unit/test_v3.py",
"patchSetId": 2
},
"lineNbr": 8161,
"author": {
"id": 4146
},
"writtenOn": "2022-05-16T23:05:38Z",
"side": 1,
"message": "I think the docs confusion also leads to some confusion here. Why isn\u0027t project-test also running if it ran on the previous change at line 8157? Seems like it should\u0027ve have run there?",
"revId": "46fe62abc0d74925dc1c513838cc2aaf5e7c319a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}