zuul/zuul
Code Issues Proposed changes

Status: Don't raise "abort" as error to the user

Browse Source 
If the request was aborted, the failure should not be presented
to the user as nothing actually went wrong.

This happens when a request is not finished when next 'update'
starts. This is amplified by the page visibility events that
will start an 'update' loop prematurely.

Without this, switching between tabs often causes the user to
see a "status.json: abort" message when they come back to the
dashboard.

Also remove redundant (and incorrectly labeled) arguments.

Change-Id: I834384535f8d04d1274336bc993c20035be01d60
This commit is contained in:
Timo Tijhof 2015-04-10 00:33:50 +01:00
parent af8ff837d5
commit 67f4ac16d5
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
etc/status/public_html/jquery.zuul.js
View File

@ -682,7 +682,10 @@
data.result_event_queue.length : '0'
);
})
.fail(function (err, jqXHR, errMsg) {
.fail(function (jqXHR, statusText, errMsg) {
if (statusText === 'abort') {
return;
}
$msg.text(options.source + ': ' + errMsg)
.addClass('alert-danger')
.removeClass('zuul-msg-wrap-off')