zuul
/
zuul
Code Issues Proposed changes

Merge "Close command socket after sending stop" into feature/zuulv3

This commit is contained in:
Zuul 2017-09-07 19:11:14 +00:00 committed by Gerrit Code Review
parent b143da59fe 03b41eecd5
commit 6caef39779
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
zuul/lib/commandsocket.py
View File

@ -44,9 +44,9 @@ class CommandSocket(object):
# First, wake up our listener thread with a connection and
# tell it to stop running.
self.running = False
s = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)
s.connect(self.path)
s.sendall(b'_stop\n')
with socket.socket(socket.AF_UNIX, socket.SOCK_STREAM) as s:
s.connect(self.path)
s.sendall(b'_stop\n')
# The command '_stop' will be ignored by our listener, so
# directly inject it into the queue so that consumers of this
# class which are waiting in .get() are awakened. They can