Browse Source

Use zuul/web/static in setup_hook

The actual location of the files we want to put into the wheel are the
files at zuul/web static. web/build is just a symlink so that the
javascript build system in web/ puts files where we want them without
needing to do build config things.

There is no actual difference - python processes the symlinks just as
well as it processes the direct paths. But from a semantic perspective,
pointing to the paths as they will be in the wheel makes a little more
sense than pointing to paths through a convenience symlink, when trying
to sort out what's going on and why.

Change-Id: Ib93b0eb22f0096b33bcfdb862a47765e48be7203
changes/64/609764/3
Monty Taylor 3 years ago
parent
commit
733623f328
No known key found for this signature in database GPG Key ID: 7BAE94BC7141A594
  1. 2
      zuul/_setup_hook.py

2
zuul/_setup_hook.py

@ -28,7 +28,7 @@ def _build_javascript():
r = subprocess.Popen(['yarn', 'install', '-d'], cwd="web/").wait()
if r:
raise RuntimeError("Yarn install failed")
if not os.path.exists('web/build/index.html'):
if not os.path.exists('zuul/web/static/index.html'):
r = subprocess.Popen(['yarn', 'build'], cwd="web/").wait()
if r:
raise RuntimeError("Yarn build failed")

Loading…
Cancel
Save