zuul
/
zuul
Code Issues Proposed changes

tests: remove test_repo_repr 

TestMergerRepo.test_repo_repr attempts to clone from a remote named
"remote". Since that is most probably is never reacheable, it would
times out after 60 seconds, only to then assert against the object
representation.

The test has little value by itself, the Repo.__repr__ method is
explicit. In the future, git blame can be used to identify why
local_path is added to the repr (id is not enough to disambiguate).

Change-Id: I96b4245f1c1ce441240d24231b3d3c07017f3ef0
This commit is contained in:
Antoine Musso 2020-01-21 22:55:46 +01:00
parent 6a9c4d16f3
commit 762607a8b2
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/unit/test_merger_repo.py
View File

@ -296,12 +296,6 @@ class TestMergerRepo(ZuulTestCase):
self.assertEqual(sorted(['messy1.txt', 'messy2.txt']),
sorted(changed_files))
def test_repo_repr(self):
local_path = "/dev/null"
repo = Repo("remote", local_path,
"none@example.org", "User Name", "0", "0")
self.assertIn(local_path, repr(repo))
def test_update_needed(self):
parent_path = os.path.join(self.upstream_root, 'org/project1')
repo = git.Repo(parent_path)