Update patch set 8

Patch Set 8: Code-Review-1

(1 comment)

Patch-set: 8
Label: Code-Review=-1

c07eb5e9c907d7e6566e15e5330a08b44cd58bda

@@ -86,6 +86,23 @@
       "revId": "c07eb5e9c907d7e6566e15e5330a08b44cd58bda",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "1a1ced50_9bba2d6d",
+        "filename": "playbooks/roles/prepare-workspace/defaults/main.yaml",
+        "patchSetId": 8
+      },
+      "lineNbr": 2,
+      "author": {
+        "id": 6488
+      },
+      "writtenOn": "2017-03-20T23:45:03Z",
+      "side": 1,
+      "message": "My personal feeling is that we should follow the practices of the Ansible community. I\u0027ve not looked outside the walls of Ursula much, but it seems to me that a global zuul_workspace variable is fine for zuul\u0027s own roles, and then anything else should accept paths as role parameters.",
+      "revId": "c07eb5e9c907d7e6566e15e5330a08b44cd58bda",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
     }
   ]
 }