zuul/zuul
Code Issues Proposed changes

Run docker-compose up test setup script with env

Browse Source 
When not using a ROOTCMD when running the test-setup-docker.sh the
script will fail with the following error message:

    ++ id -u
    + USER_ID=1000 docker-compose up -d
    ./test-setup-docker.sh: line 50: USER_ID=1000: command not found

Due to Bash's simple command expansion[0] variable assignments will be
interpreted as the command when no ROOTCMD is given. To work around this
we use default ROOTCMD to the `env` command.

[0]: https://www.gnu.org/savannah-checkouts/gnu/bash/manual/bash.html#Simple-Command-Expansion

Change-Id: Id696069a4eec2b2c2513ac449098b0ef73dc3906
This commit is contained in:
Simon Westphahl 2022-08-23 13:31:54 +02:00
parent 4c3dd064d7
commit 7b68214ea6
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tools/test-setup-docker.sh
View File

@ -8,7 +8,11 @@
# environment.
set -xeu
ROOTCMD=${ROOTCMD:-}
# Default ROOTCMD to the 'env' command, otherwise variable assignments will be
# interpreted as command when no ROOTCMD is given. The reason for that is
# Bash's simple command expansion.
ROOTCMD=${ROOTCMD:-env}
cd $(dirname $0)
SCRIPT_DIR="$(pwd)"