From 7bbd7a3ef9971a1a915d8046bf2f00658d931a6e Mon Sep 17 00:00:00 2001 From: "James E. Blair" Date: Mon, 6 Mar 2017 11:36:13 -0800 Subject: [PATCH] Add missing pauses in reconfiguration tests We need to wait for zuul to settle before we can presume that the new configuration is in place. Change-Id: I47354c98325df12cf8180c77e6f34f738874ecc7 --- tests/unit/test_v3.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/unit/test_v3.py b/tests/unit/test_v3.py index e566479e5a..3a4e164286 100644 --- a/tests/unit/test_v3.py +++ b/tests/unit/test_v3.py @@ -116,6 +116,7 @@ class TestInRepoConfig(ZuulTestCase): dict(name='project-test2', result='SUCCESS', changes='1,1')]) self.fake_gerrit.addEvent(A.getChangeMergedEvent()) + self.waitUntilSettled() # Now that the config change is landed, it should be live for # subsequent changes. @@ -164,6 +165,7 @@ class TestInRepoConfig(ZuulTestCase): self.assertHistory([ dict(name='project-test2', result='SUCCESS', changes='1,1')]) self.fake_gerrit.addEvent(A.getChangeMergedEvent()) + self.waitUntilSettled() # The config change should not affect master. B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')