zuul/zuul
Code Issues Proposed changes

Merge "Handle jwt decoding error, fix exception default messages"

Browse Source
This commit is contained in:
Zuul
2022-07-14 18:29:09 +00:00
committed by Gerrit Code Review
parent cce45ec1dd 03878ee643
commit 8434446c98
3 changed files with 38 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
zuul/lib/auth.py
View File

@@ -74,10 +74,14 @@ class AuthenticatorRegistry(object):
cpb.capabilities_registry.register_capabilities('auth', capabilities)
def authenticate(self, rawToken):
unverified = jwt.decode(rawToken, options={'verify_signature': False})
for auth_name in self.authenticators:
authenticator = self.authenticators[auth_name]
if authenticator.issuer_id == unverified.get('iss', ''):
return authenticator.authenticate(rawToken)
try:
unverified = jwt.decode(rawToken,
options={'verify_signature': False})
for auth_name in self.authenticators:
authenticator = self.authenticators[auth_name]
if authenticator.issuer_id == unverified.get('iss', ''):
return authenticator.authenticate(rawToken)
except jwt.exceptions.DecodeError:
raise exceptions.AuthTokenUndecodedException(self.default_realm)
# No known issuer found, use default realm
raise exceptions.IssuerUnknownError(self.default_realm)