From 8d73c2d2fd5074592b0b8028962cd22a46ff29d2 Mon Sep 17 00:00:00 2001 From: Clark Boylan Date: Tue, 19 Feb 2019 09:50:37 -0800 Subject: [PATCH] Clarify project vs repository in getPullBySha There continues to be some slightly confusing var terminology in getPullBySha. Rename the project_name suffix variable to repository from project to match the github3 term. Change-Id: I5e34fcb80248532f97b470d7f829dd5c4577e5f3 --- zuul/driver/github/githubconnection.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/zuul/driver/github/githubconnection.py b/zuul/driver/github/githubconnection.py index 94c989e062..dfe2091033 100644 --- a/zuul/driver/github/githubconnection.py +++ b/zuul/driver/github/githubconnection.py @@ -1206,8 +1206,8 @@ class GithubConnection(BaseConnection): pulls = [] github = self.getGithubClient(project_name) - owner, project = project_name.split('/') - repo = github.repository(owner, project) + owner, repository = project_name.split('/') + repo = github.repository(owner, repository) for pr in repo.pull_requests(state='open', # We sort by updated from oldest to newest # as that will prefer more recently