zuul
/
zuul
Code Issues Proposed changes

Don't mask exceptions in _process_event 

For better logs we emit start and end messages before and after github
event processing. However the return of the event is part of the
finally clause which inhibits any exception from bubbling up. Moving
the return out of the finally clause fixes this so exceptions can be
caught by the caller and logged.

Change-Id: I25b40fe595eb149e0b52156aeceff9b464130d7f
This commit is contained in:
Tobias Henkel 2020-07-21 17:10:04 +02:00
parent c0431ddd63
commit 8f20771e99
No known key found for this signature in database
GPG Key ID: 03750DEC158E5FA2
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
zuul/driver/github/githubconnection.py
View File

@ -363,7 +363,7 @@ class GithubEventProcessor(object):
self._process_event()
finally:
self.log.debug("Finished event processing")
return self.event
return self.event
def _process_event(self):
if self.connector._stopped: