From dd6556f37618700f9975402019013038efe42fe7 Mon Sep 17 00:00:00 2001 From: Monty Taylor Date: Tue, 27 Aug 2019 09:41:57 +0200 Subject: [PATCH] Make json outfile seeking clearer The magic number of 2 can be replaced by os.SEEK_END, and the seek call returns the length, so we don't need the tell call. Change-Id: I1aa5b568d9aab89440e221f8e09b552d05f2cc53 --- zuul/ansible/base/callback/zuul_json.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/zuul/ansible/base/callback/zuul_json.py b/zuul/ansible/base/callback/zuul_json.py index d3c88b4528..4a2edcf6e6 100644 --- a/zuul/ansible/base/callback/zuul_json.py +++ b/zuul/ansible/base/callback/zuul_json.py @@ -186,10 +186,10 @@ class CallbackModule(CallbackBase): self._append_playbook(outfile, first_time) def _append_playbook(self, outfile, first_time): - outfile.seek(0, 2) + file_len = outfile.seek(0, os.SEEK_END) # Remove three bytes to eat the trailing newline written by the # json.dump. This puts the ',' on the end of lines. - outfile.seek(outfile.tell() - 3) + outfile.seek(file_len - 3) if not first_time: outfile.write(',\n') json.dump(self.playbook, outfile,