zuul/zuul
Code Issues Proposed changes

Rename 'repos' job attribute to 'required-projects'

Browse Source 
The name 'repos' is not clear, especially since we have removed
most other occurences of that word.  It's not obvious that the
values should be names of Zuul projects.  We might simply use
'projects' instead, but there is a concern that users may see
that as saying this job should *run on* these projects (ie, as
a replacement for the project-pipeline configuration).  Hopefully
'required-projects' indicates that the job utilizes the projects
in the list.

Change-Id: I43af7a7f688f1368514427a2892a03d1cf46fe72
This commit is contained in:
James E. Blair
2017-05-23 13:11:25 -07:00
parent 27f3dfc77e
commit 912322fcd3
4 changed files with 30 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
zuul/executor/client.py
View File

@@ -300,8 +300,8 @@ class ExecutorClient(object):
override_branch=override_branch,
default_branch=project_default_branch)
if job.repos:
for job_project in job.repos.values():
if job.required_projects:
for job_project in job.required_projects.values():
(trusted, project) = tenant.getProject(
job_project.project_name)
if project is None: