zuul
/
zuul
Code Issues Proposed changes

Remove reported_enqueue flag from queue item 

It seems that we check for the reported_enqueue flag only when
initially enqueueing an item. This we can remove it and save a
zookeeper operation when enqueueing a change.

Change-Id: Ic869698e882377217410ea66825c5c999f9ae322
This commit is contained in:
Tobias Henkel 2021-11-16 22:38:24 +01:00
parent 9b1f2838d7
commit 92bbc2fe02
No known key found for this signature in database
GPG Key ID: 03750DEC158E5FA2
2 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
zuul/manager/__init__.py
View File

@ -546,10 +546,8 @@ class PipelineManager(metaclass=ABCMeta):
self.reportStats(item, added=True)
item.quiet = quiet
if item.live and not item.reported_enqueue:
if item.live:
self.reportEnqueue(item)
item.updateAttributes(self.current_context,
reported_enqueue=True)
# Items in a dependency cycle are expected to be enqueued after
# each other. To prevent non-cycle items from being enqueued

2
zuul/model.py
View File

@ -3930,7 +3930,6 @@ class QueueItem(zkobject.ZKObject):
report_time=None,
dequeue_time=None,
reported=False,
reported_enqueue=False,
reported_start=False,
quiet=False,
active=False, # Whether an item is within an active window
@ -3989,7 +3988,6 @@ class QueueItem(zkobject.ZKObject):
"report_time": self.report_time,
"dequeue_time": self.dequeue_time,
"reported": self.reported,
"reported_enqueue": self.reported_enqueue,
"reported_start": self.reported_start,
"quiet": self.quiet,
"active": self.active,