Merge "Move tenant_config option to scheduler section" into feature/zuulv3

doc/source/admin/quick-start.rst

@@ -54,7 +54,7 @@ service in Zuul, and a connection to Gerrit.
 
 **zuul.conf**::
 
-    [zuul]
+    [scheduler]
     tenant_config=/etc/zuul/main.yaml
 
     [gearman_server]

tests/base.py

@@ -1898,12 +1898,13 @@ class ZuulTestCase(BaseTestCase):
             shutil.copy('{}.pub'.format(src_private_key_file),
                         '{}.pub'.format(self.private_key_file))
             os.chmod(self.private_key_file, 0o0600)
-        self.config.set('zuul', 'tenant_config',
-                        os.path.join(FIXTURE_DIR,
-                                     self.config.get('zuul', 'tenant_config')))
+        self.config.set('scheduler', 'tenant_config',
+                        os.path.join(
+                            FIXTURE_DIR,
+                            self.config.get('scheduler', 'tenant_config')))
+        self.config.set('zuul', 'state_dir', self.state_root)
         self.config.set('merger', 'git_dir', self.merger_src_root)
         self.config.set('executor', 'git_dir', self.executor_src_root)
-        self.config.set('zuul', 'state_dir', self.state_root)
         self.config.set('executor', 'private_key_file', self.private_key_file)
 
         self.statsd = FakeStatsd()
@@ -2045,9 +2046,14 @@ class ZuulTestCase(BaseTestCase):
         self.config = configparser.ConfigParser()
         self.config.read(os.path.join(FIXTURE_DIR, self.config_file))
 
+        sections = ['zuul', 'scheduler', 'executor', 'merger']
+        for section in sections:
+            if not self.config.has_section(section):
+                self.config.add_section(section)
+
         if not self.setupSimpleLayout():
             if hasattr(self, 'tenant_config_file'):
-                self.config.set('zuul', 'tenant_config',
+                self.config.set('scheduler', 'tenant_config',
                                 self.tenant_config_file)
                 git_path = os.path.join(
                     os.path.dirname(
@@ -2105,7 +2111,7 @@ class ZuulTestCase(BaseTestCase):
                                 'untrusted-projects': untrusted_projects}}}}]
         f.write(yaml.dump(config).encode('utf8'))
         f.close()
-        self.config.set('zuul', 'tenant_config',
+        self.config.set('scheduler', 'tenant_config',
                         os.path.join(FIXTURE_DIR, f.name))
 
         self.init_repo('common-config')
@@ -2118,7 +2124,7 @@ class ZuulTestCase(BaseTestCase):
         if self.create_project_keys:
             return
 
-        path = self.config.get('zuul', 'tenant_config')
+        path = self.config.get('scheduler', 'tenant_config')
         with open(os.path.join(FIXTURE_DIR, path)) as f:
             tenant_config = yaml.safe_load(f.read())
         for tenant in tenant_config:
@@ -2627,7 +2633,7 @@ class ZuulTestCase(BaseTestCase):
           - org/project1
           - org/project2\n""" % path)
         f.close()
-        self.config.set('zuul', 'tenant_config',
+        self.config.set('scheduler', 'tenant_config',
                         os.path.join(FIXTURE_DIR, f.name))
         self.setupAllProjectKeys()
 

tests/fixtures/zuul-connections-gerrit-and-github.conf

@@ -1,7 +1,7 @@
 [gearman]
 server=127.0.0.1
 
-[zuul]
+[scheduler]
 tenant_config=config/multi-driver/main.yaml
 
 [merger]

tests/fixtures/zuul-connections-multiple-gerrits.conf

@@ -1,7 +1,7 @@
 [gearman]
 server=127.0.0.1
 
-[zuul]
+[scheduler]
 tenant_config=main.yaml
 
 [merger]

tests/fixtures/zuul-connections-same-gerrit.conf

@@ -1,7 +1,7 @@
 [gearman]
 server=127.0.0.1
 
-[zuul]
+[scheduler]
 tenant_config=config/zuul-connections-same-gerrit/main.yaml
 
 [merger]

tests/fixtures/zuul-git-driver.conf

@@ -1,7 +1,7 @@
 [gearman]
 server=127.0.0.1
 
-[zuul]
+[scheduler]
 tenant_config=config/zuul-connections-same-gerrit/main.yaml
 
 [merger]

tests/fixtures/zuul-sql-driver.conf

@@ -1,9 +1,8 @@
 [gearman]
 server=127.0.0.1
 
-[zuul]
+[scheduler]
 tenant_config=main.yaml
-url_pattern=http://logs.example.com/{change.number}/{change.patchset}/{pipeline.name}/{job.name}/{build.number}
 
 [merger]
 git_dir=/tmp/zuul-test/merger-git

tests/fixtures/zuul.conf

@@ -1,7 +1,7 @@
 [gearman]
 server=127.0.0.1
 
-[zuul]
+[scheduler]
 tenant_config=main.yaml
 
 [merger]

zuul/scheduler.py

@@ -451,7 +451,7 @@ class Scheduler(threading.Thread):
             self.log.debug("Performing reconfiguration")
             loader = configloader.ConfigLoader()
             abide = loader.loadConfig(
-                self.config.get('zuul', 'tenant_config'),
+                self.config.get('scheduler', 'tenant_config'),
                 self._get_project_key_dir(),
                 self, self.merger, self.connections)
             for tenant in abide.tenants.values():
@@ -468,7 +468,7 @@ class Scheduler(threading.Thread):
             self.log.debug("Performing tenant reconfiguration")
             loader = configloader.ConfigLoader()
             abide = loader.reloadTenant(
-                self.config.get('zuul', 'tenant_config'),
+                self.config.get('scheduler', 'tenant_config'),
                 self._get_project_key_dir(),
                 self, self.merger, self.connections,
                 self.abide, event.tenant)