From a5d6edbae7b2ac5d84413eafdf66fd89e4928ab7 Mon Sep 17 00:00:00 2001 From: "James E. Blair" Date: Mon, 14 Jan 2019 16:19:29 -0800 Subject: [PATCH] Log connection exceptions when starting web If there are errors setting up the connections (eg, a recently seen possible example related to sql migrations), we should log them. Change-Id: I39a51514c1c2277106e11682dedde410372b50e5 --- zuul/cmd/web.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/zuul/cmd/web.py b/zuul/cmd/web.py index c77a5db430..ed6b12b0fb 100755 --- a/zuul/cmd/web.py +++ b/zuul/cmd/web.py @@ -92,11 +92,10 @@ class WebServer(zuul.cmd.ZuulDaemonApp): self.setup_logging('web', 'log_config') self.log = logging.getLogger("zuul.WebServer") - self.configure_connections( - include_drivers=[zuul.driver.sql.SQLDriver, - zuul.driver.github.GithubDriver]) - try: + self.configure_connections( + include_drivers=[zuul.driver.sql.SQLDriver, + zuul.driver.github.GithubDriver]) self._run() except Exception: self.log.exception("Exception from WebServer:")