From aa350543b47d98c378876e1d414ed49b1d6ec6b5 Mon Sep 17 00:00:00 2001 From: Clark Boylan Date: Thu, 30 May 2019 14:26:24 -0700 Subject: [PATCH] Use nodejs v10 in testing We currently use a mix of nodejs 6, 8, and 10 across different jobs. Lets standardize on nodejs 10 everywhere. Change-Id: Iec9bbf270589029d10c60ed602817e853c6e5bc4 --- .zuul.yaml | 2 ++ tools/pip.sh | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.zuul.yaml b/.zuul.yaml index a9c69a37e6..846dc8ef91 100644 --- a/.zuul.yaml +++ b/.zuul.yaml @@ -72,6 +72,7 @@ javascript_content_dir: "../zuul/web/static" zuul_work_dir: "{{ zuul.project.src_dir }}/web" zuul_api_url: https://zuul.openstack.org + node_version: 10 run: playbooks/dashboard/run.yaml - job: @@ -79,6 +80,7 @@ parent: zuul-build-dashboard vars: zuul_api_url: https://softwarefactory-project.io/zuul + node_version: 10 # This job is run on changes to both Zuul and Nodepool; any changes to # the other project will be picked up via image builds which appear in diff --git a/tools/pip.sh b/tools/pip.sh index 489bdf9107..402f43d217 100755 --- a/tools/pip.sh +++ b/tools/pip.sh @@ -23,7 +23,7 @@ then pip install nodeenv # Initialize nodeenv and tell it to re-use the currently active virtualenv # TODO(jeblair): remove node version pin. upath 1.0.4 objects to node >9. - nodeenv --python-virtualenv -n 8.11.1 + nodeenv --python-virtualenv -n 10.16.0 # Use -g because inside of the virtualenv '-g' means 'install into the' # virtualenv - as opposed to installing into the local node_modules. # Avoid writing a package-lock.json file since we don't use it.