zuul
/
zuul
Code Issues Proposed changes

Use nodejs v10 in testing 

We currently use a mix of nodejs 6, 8, and 10 across different jobs.
Lets standardize on nodejs 10 everywhere.

Change-Id: Iec9bbf270589029d10c60ed602817e853c6e5bc4
This commit is contained in:
Clark Boylan 2019-05-30 14:26:24 -07:00
parent 1f8ec8499f
commit aa350543b4
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.zuul.yaml
View File

@ -72,6 +72,7 @@
javascript_content_dir: "../zuul/web/static" javascript_content_dir: "../zuul/web/static"
zuul_work_dir: "{{ zuul.project.src_dir }}/web" zuul_work_dir: "{{ zuul.project.src_dir }}/web"
zuul_api_url: https://zuul.openstack.org zuul_api_url: https://zuul.openstack.org
node_version: 10
run: playbooks/dashboard/run.yaml run: playbooks/dashboard/run.yaml
- job: - job:
@ -79,6 +80,7 @@
parent: zuul-build-dashboard parent: zuul-build-dashboard
vars: vars:
zuul_api_url: https://softwarefactory-project.io/zuul zuul_api_url: https://softwarefactory-project.io/zuul
node_version: 10
# This job is run on changes to both Zuul and Nodepool; any changes to # This job is run on changes to both Zuul and Nodepool; any changes to
# the other project will be picked up via image builds which appear in # the other project will be picked up via image builds which appear in

2
tools/pip.sh
View File

@ -23,7 +23,7 @@ then
pip install nodeenv pip install nodeenv
# Initialize nodeenv and tell it to re-use the currently active virtualenv # Initialize nodeenv and tell it to re-use the currently active virtualenv
# TODO(jeblair): remove node version pin. upath 1.0.4 objects to node >9. # TODO(jeblair): remove node version pin. upath 1.0.4 objects to node >9.
nodeenv --python-virtualenv -n 8.11.1 nodeenv --python-virtualenv -n 10.16.0
# Use -g because inside of the virtualenv '-g' means 'install into the' # Use -g because inside of the virtualenv '-g' means 'install into the'
# virtualenv - as opposed to installing into the local node_modules. # virtualenv - as opposed to installing into the local node_modules.
# Avoid writing a package-lock.json file since we don't use it. # Avoid writing a package-lock.json file since we don't use it.