zuul
/
zuul
Code Issues Proposed changes

Update patch set 27 

Patch Set 27:

(1 comment)

> Patch Set 26:
> 
> (1 comment)
> 
> thx for your review, i check to optimize and send a New patchet

Patch-set: 27
Reviewer: Gerrit User 29946 <29946@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 29946 2021-02-03 18:49:15 +00:00 committed by Gerrit Code Review
parent cdb3bdcfa0
commit b2f8b68b3c
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
861e92ac4b7118a95492492b3477f701ee69693b
View File

@ -34,6 +34,24 @@
"revId": "861e92ac4b7118a95492492b3477f701ee69693b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "c06d60a0_0611fa0d",
"filename": "web/src/containers/config/Config.jsx",
"patchSetId": 26
},
"lineNbr": 117,
"author": {
"id": 29946
},
"writtenOn": "2021-02-03T18:49:15Z",
"side": 1,
"message": "timezone from moment are lot of region, for this reason i use select component with variant typehead instead of FormSelect\n\nAlso i add a maxHeight to force scrolling bar (https://imgur.com/a/2QBkpJH)",
"parentUuid": "e1d83759_1c282393",
"revId": "861e92ac4b7118a95492492b3477f701ee69693b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}