From 3d97866e0d20a0ded6077bc4193c88dafa9dee2b Mon Sep 17 00:00:00 2001 From: "James E. Blair" Date: Mon, 31 Mar 2025 11:13:59 -0700 Subject: [PATCH] Remove unecessary code from manager._postConfig We don't need to clear the layout cache in _postConfig because the configloader creates a new pipeline manager in all cases where this method would be called anyway (that is: a tenant reconfiguration). Remove this unecessary code and the potentially confusing comment that goes with it. Change-Id: I7ee0f08688a084d6fd706877f1453f8fd29a9e65 --- zuul/manager/__init__.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/zuul/manager/__init__.py b/zuul/manager/__init__.py index 1aa2074619..a271580f22 100644 --- a/zuul/manager/__init__.py +++ b/zuul/manager/__init__.py @@ -106,12 +106,6 @@ class PipelineManager(metaclass=ABCMeta): self.current_context = None def _postConfig(self): - # After a reconfiguration, we need to forget anything built - # from the old layout. - # TODO: we may be able to preserve change queues if projects - # haven't changed their pipeline participation. - self._layout_cache = {} - layout = self.tenant.layout self.buildChangeQueues(layout) # Make sure we have state and change list objects. We