zuul
/
zuul
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 20676 \u003c20676@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"daniel.pawlik replied on the change"}
This commit is contained in:
Gerrit User 20676 2022-05-16 12:04:40 +00:00 committed by Gerrit Code Review
parent 1d39ea6861
commit bfc30eaac3
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
66844797d21da391447ec80731381649b45cb69e
View File

@ -33,6 +33,23 @@
"message": "\u003e Patch Set 1:\n\u003e \n\u003e We similarly discovered that network interface interrogation in the Ansible stdlib relies on the netaddr package, but doesn\u0027t declare a dependency on it (hence why it got appended to the list recently). Dropping ARA caused a regression for a bunch of jobs in OpenDev (and likely elsewhere) because ARA declared a dependency on netaddr and so was implicitly providing it in the venv.\n\u003e \n\u003e This raises a larger question, should Ansible be delcaring dependencies on modules used by its stdlib?\n\nIMO yes and it was strange for me, that those libraries are not included by default into requirements.txt file. I will try to talk with Ansible team to get answer.",
"revId": "66844797d21da391447ec80731381649b45cb69e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ec08c1d3_049a49a6",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 20676
},
"writtenOn": "2022-05-16T12:04:40Z",
"side": 1,
"message": "\u003e Patch Set 1:\n\u003e \n\u003e We similarly discovered that network interface interrogation in the Ansible stdlib relies on the netaddr package, but doesn\u0027t declare a dependency on it (hence why it got appended to the list recently). Dropping ARA caused a regression for a bunch of jobs in OpenDev (and likely elsewhere) because ARA declared a dependency on netaddr and so was implicitly providing it in the venv.\n\u003e \n\u003e This raises a larger question, should Ansible be delcaring dependencies on modules used by its stdlib?\n\nCreated an issue in Ansible project: https://github.com/ansible/ansible/issues/77808",
"revId": "66844797d21da391447ec80731381649b45cb69e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}