Merge "Update to create-react-app 3.4.1"

tests/unit/test_web_urls.py

@@ -51,6 +51,9 @@ class TestWebURLs(ZuulTestCase):
         ]:
             for item in page.find_all(tag):
                 suburl = item.get(attr)
+                if tag == 'script' and suburl is None:
+                    # There can be an embedded script
+                    continue
                 if suburl.startswith('/'):
                     suburl = suburl[1:]
                 link = urllib.parse.urljoin(url, suburl)

web/.eslintrc

@@ -18,7 +18,7 @@ extends:
   - plugin:react/recommended
 settings:
   react:
-    version: "16.4"
+    version: "16.13"
 env:
   jest/globals: true
   browser: true

web/package.json

@@ -14,28 +14,31 @@
     "moment": "^2.22.2",
     "moment-duration-format": "2.3.2",
     "moment-timezone": "^0.5.28",
-    "patternfly-react": "^2.13.1",
+    "patternfly-react": "^2.39.16",
     "prop-types": "^15.6.2",
-    "react": "^16.4.2",
+    "react": "^16.13.1",
-    "react-dom": "^16.4.2",
+    "react-dom": "^16.13.1",
     "react-height": "^3.0.0",
     "react-json-view": "^1.19.1",
-    "react-redux": "^5.0.7",
+    "react-redux": "<7.1.1",
     "react-router": "^4.3.1",
     "react-router-dom": "^4.3.1",
-    "react-scripts": "1.1.4",
+    "react-scripts": "3.4.1",
     "react-select": "3.1.0",
-    "redux": "<4.0.0",
+    "redux": "^4.0.5",
     "redux-thunk": "^2.3.0",
     "sockette": "^2.0.0",
     "swagger-ui": "^3.20.1",
     "xterm": "^3.14.5"
   },
+  "resolutions": {
+    "formdata-node": "2.1.1",
+    "nanoid": "2.1.11"
+  },
   "devDependencies": {
-    "eslint": "^5.3.0",
+    "eslint-plugin-jest": "^23.8.2",
-    "eslint-plugin-jest": "^21.21.0",
+    "eslint-plugin-react": "^7.19.0",
-    "eslint-plugin-react": "^7.11.1",
+    "eslint-plugin-standard": "^4.0.1",
-    "eslint-plugin-standard": "^3.1.0",
     "yarn": "^1.16.0"
   },
   "scripts": {
@@ -47,5 +50,11 @@
     "test": "react-scripts test --env=jsdom",
     "eject": "react-scripts eject",
     "lint": "eslint --ext .js --ext .jsx src"
-  }
+  },
+  "browserslist": [
+    ">0.2%",
+    "not dead",
+    "not ie <= 11",
+    "not op_mini all"
+  ]
 }

web/src/App.test.jsx

@@ -1,4 +1,3 @@
-/* global Promise, expect, jest, it, location */
 // Copyright 2018 Red Hat, Inc
 //
 // Licensed under the Apache License, Version 2.0 (the "License"); you may

web/src/actions/build.test.js

@@ -1,4 +1,3 @@
-/* global expect, it */
 // Copyright 2019 Red Hat, Inc
 //
 // Licensed under the Apache License, Version 2.0 (the "License"); you may

web/src/actions/change.js

@@ -1,4 +1,3 @@
-/* global Promise */
 // Copyright 2018 Red Hat, Inc
 //
 // Licensed under the Apache License, Version 2.0 (the "License"); you may

web/src/actions/job.js

@@ -1,4 +1,3 @@
-/* global Promise */
 // Copyright 2018 Red Hat, Inc
 //
 // Licensed under the Apache License, Version 2.0 (the "License"); you may

web/src/actions/jobs.js

@@ -1,4 +1,3 @@
-/* global Promise */
 // Copyright 2018 Red Hat, Inc
 //
 // Licensed under the Apache License, Version 2.0 (the "License"); you may

web/src/actions/project.js

@@ -1,4 +1,3 @@
-/* global Promise */
 // Copyright 2018 Red Hat, Inc
 //
 // Licensed under the Apache License, Version 2.0 (the "License"); you may

web/src/actions/projects.js

@@ -1,4 +1,3 @@
-/* global Promise */
 // Copyright 2018 Red Hat, Inc
 //
 // Licensed under the Apache License, Version 2.0 (the "License"); you may

web/src/actions/status.js

@@ -1,4 +1,3 @@
-/* global Promise */
 // Copyright 2018 Red Hat, Inc
 //
 // Licensed under the Apache License, Version 2.0 (the "License"); you may

web/src/api.js

@@ -1,4 +1,4 @@
-/* global process, window */
+/* global process */
 // Copyright 2018 Red Hat, Inc
 //
 // Licensed under the Apache License, Version 2.0 (the "License"); you may

web/src/containers/Refreshable.jsx

@@ -44,6 +44,8 @@ class Refreshable extends React.Component {
     const { remoteData } = this.props
     return (
       <Spinner loading={ remoteData.isFetching }>
+        {/* Lint warning jsx-a11y/anchor-is-valid */}
+        {/* eslint-disable-next-line */}
         <a className="refresh" onClick={() => {this.updateData(true)}}>
           <Icon type="fa" name="refresh" /> refresh&nbsp;&nbsp;
         </a>

web/src/containers/TableFilters.jsx

@@ -1,4 +1,3 @@
-/* global URLSearchParams */
 // Copyright 2018 Red Hat, Inc
 //
 // Licensed under the Apache License, Version 2.0 (the "License"); you may

web/src/containers/status/ChangePanel.test.jsx

@@ -1,4 +1,3 @@
-/* global expect, it */
 // Copyright 2018 Red Hat, Inc
 //
 // Licensed under the Apache License, Version 2.0 (the "License"); you may

web/src/pages/ChangeStatus.jsx

@@ -1,4 +1,3 @@
-/* global setTimeout, clearTimeout */
 // Copyright 2018 Red Hat, Inc
 //
 // Licensed under the Apache License, Version 2.0 (the "License"); you may

web/src/pages/ConfigErrors.jsx

@@ -37,6 +37,8 @@ class ConfigErrorsPage extends React.Component {
     return (
       <React.Fragment>
         <div className="pull-right">
+          {/* Lint warning jsx-a11y/anchor-is-valid */}
+          {/* eslint-disable-next-line */}
           <a className="refresh" onClick={() => {this.updateData()}}>
             <Icon type="fa" name="refresh" /> refresh&nbsp;&nbsp;
           </a>

web/src/pages/Status.jsx

@@ -1,4 +1,3 @@
-/* global setTimeout, clearTimeout */
 // Copyright 2018 Red Hat, Inc
 //
 // Licensed under the Apache License, Version 2.0 (the "License"); you may

web/src/pages/Stream.jsx

@@ -1,4 +1,3 @@
-/* global JSON, URLSearchParams */
 // Copyright 2018 Red Hat, Inc
 //
 // Licensed under the Apache License, Version 2.0 (the "License"); you may