zuul/zuul
Code Issues Proposed changes

Return dependency cycle failure to user

Browse Source 
This change changes the dependency cycle error handling in order
to report the error to the user via the standard report mechanics.

Change-Id: I7cdbd9b7b48fd612b2887007b70acedd7a8e3113
This commit is contained in:
Fabien Boucher
2019-07-24 12:12:51 +02:00
parent 5969c949b4
commit c2a33fcb9c
6 changed files with 30 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/unit/test_gerrit_legacy_crd.py
View File

@@ -270,7 +270,7 @@ class TestGerritLegacyCRD(ZuulTestCase):
self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
self.waitUntilSettled()
self.assertEqual(A.reported, 0)
self.assertEqual(A.reported, 1)
self.assertEqual(B.reported, 0)
self.assertEqual(A.data['status'], 'NEW')
self.assertEqual(B.data['status'], 'NEW')
@@ -609,8 +609,8 @@ class TestGerritLegacyCRD(ZuulTestCase):
self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
self.waitUntilSettled()
# Dependency cycle injected so zuul should not have reported again on A
self.assertEqual(A.reported, 1)
# Dependency cycle injected so zuul should have reported again on A
self.assertEqual(A.reported, 2)
# Now if we update B to remove the depends-on, everything
# should be okay. B; A->B
@@ -621,7 +621,7 @@ class TestGerritLegacyCRD(ZuulTestCase):
self.waitUntilSettled()
# Cycle was removed so now zuul should have reported again on A
self.assertEqual(A.reported, 2)
self.assertEqual(A.reported, 3)
self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
self.waitUntilSettled()