zuul
/
zuul
Code Issues Proposed changes

Merge "Delay getting many files to mergers"

This commit is contained in:
Zuul 2021-02-27 00:37:02 +00:00 committed by Gerrit Code Review
parent 9070f59e9a 904d20c576
commit c2d3d6b9b4
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
zuul/driver/github/githubconnection.py
View File

@ -1598,7 +1598,17 @@ class GithubConnection(CachedBranchConnection):
number, owner, proj))
pr = probj.as_dict()
try:
pr['files'] = [f.filename for f in probj.files()]
if pr.get('changed_files', 0) > 999:
# Don't request more than ten pages. If we exceed this we
# need to determine the files via the mergers asynchronously
# in order to not block the event processing by iterating on
# too many pages.
self.log.warning('Pull request #%s of %s/%s has too many '
'files. Files will be requested '
'asynchronously', number, owner, proj)
pr['files'] = None
else:
pr['files'] = [f.filename for f in probj.files()]
except github3.exceptions.ServerError as exc:
# NOTE: For PRs with a lot of lines changed, Github will return
# an error (HTTP 500) because it can't generate the diff.