From ca0466e76d4b4f016df63cb107cee1847e4d6ba3 Mon Sep 17 00:00:00 2001 From: Antoine Musso Date: Thu, 27 Sep 2012 17:26:27 +0200 Subject: [PATCH] raise exception when info reference cant be found We always assume being able to get the references from a specific URL although that might not be available (for example if Apache is not properly setup). Logging an error with the URL we attempted to reach and raising the urllib2 exception will give an obvious hint to the administrator. Change-Id: I0465f8ec0749f6f16d64ddb22dd2ad93dbc42c82 Reviewed-on: https://review.openstack.org/13815 Reviewed-by: Clark Boylan Approved: James E. Blair Reviewed-by: James E. Blair Tested-by: Jenkins --- zuul/trigger/gerrit.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/zuul/trigger/gerrit.py b/zuul/trigger/gerrit.py index 4da610042e..84bead0a45 100644 --- a/zuul/trigger/gerrit.py +++ b/zuul/trigger/gerrit.py @@ -119,7 +119,11 @@ class Gerrit(object): def _getInfoRefs(self, project): url = "https://%s/p/%s/info/refs?service=git-upload-pack" % ( self.server, project) - data = urllib2.urlopen(url).read() + try: + data = urllib2.urlopen(url).read() + except: + self.log.error("Cannot get references from %s" % url) + raise # keeps urllib2 error informations ret = {} read_headers = False read_advertisement = False