zuul
/
zuul
Code Issues Proposed changes

Enhance some logging messages 

Change-Id: I257a3592643a716cd88efc255150a603d89d108a
This commit is contained in:
Antoine Musso 2020-01-25 12:28:20 +01:00
parent b9f885e2a7
commit d6beb77397
3 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tests/base.py
View File

@ -2659,8 +2659,11 @@ class RecordingExecutorServer(zuul.executor.server.ExecutorServer):
"""
builds = self.running_builds[:]
self.log.debug("Releasing build %s (%s)" % (regex,
len(self.running_builds)))
if len(builds) == 0:
self.log.debug('No running builds to release')
return
self.log.debug("Releasing build %s (%s)" % (regex, len(builds)))
for build in builds:
if not regex or re.match(regex, build.name):
self.log.debug("Releasing build %s" %
@ -2670,7 +2673,7 @@ class RecordingExecutorServer(zuul.executor.server.ExecutorServer):
self.log.debug("Not releasing build %s" %
(build.parameters['zuul']['build']))
self.log.debug("Done releasing builds %s (%s)" %
(regex, len(self.running_builds)))
(regex, len(builds)))
def executeJob(self, job):
build = FakeBuild(self, job)
@ -4599,6 +4602,10 @@ class ZuulTestCase(BaseTestCase):
completed.
"""
if not self.history:
self.log.debug("Build history: no builds ran")
return
self.log.debug("Build history:")
for build in self.history:
self.log.debug(build)

2
zuul/executor/server.py
View File

@ -2671,7 +2671,7 @@ class ExecutorServer(BaseMergeServer):
self.command_thread.daemon = True
self.command_thread.start()
self.log.debug("Starting workers")
self.log.debug("Starting %s update workers" % self.update_workers)
for i in range(self.update_workers):
update_thread = threading.Thread(target=self._updateLoop,
name='update')

6
zuul/lib/gearworker.py
View File

@ -51,18 +51,18 @@ class ZuulGearWorker:
self.ssl_cert, self.ssl_ca,
keepalive=True, tcp_keepidle=60,
tcp_keepintvl=30, tcp_keepcnt=5)
self.log.debug('Waiting for server')
self.log.debug('Waiting for gearman')
self.gearman.waitForServer()
self.register()
self.thread.start()
def register(self):
self.log.debug('Registering jobs')
self.log.debug('Registering %s jobs' % len(self.jobs))
for job in self.jobs:
self.gearman.registerFunction(job)
def unregister(self):
self.log.debug('Unregistering jobs')
self.log.debug('Unregistering all jobs (%s)' % len(self.jobs))
for job in self.jobs:
self.gearman.unRegisterFunction(job)