Make json outfile seeking clearer

The magic number of 2 can be replaced by os.SEEK_END, and the seek
call returns the length, so we don't need the tell call.

Change-Id: I1aa5b568d9aab89440e221f8e09b552d05f2cc53
This commit is contained in:
Monty Taylor
2019-08-27 09:41:57 +02:00
parent d495f2f2af
commit dd6556f376

View File

@@ -186,10 +186,10 @@ class CallbackModule(CallbackBase):
self._append_playbook(outfile, first_time)
def _append_playbook(self, outfile, first_time):
outfile.seek(0, 2)
file_len = outfile.seek(0, os.SEEK_END)
# Remove three bytes to eat the trailing newline written by the
# json.dump. This puts the ',' on the end of lines.
outfile.seek(outfile.tell() - 3)
outfile.seek(file_len - 3)
if not first_time:
outfile.write(',\n')
json.dump(self.playbook, outfile,