zuul
/
zuul
Code Issues Proposed changes

Only try to revise unaccepted node requests 

When a node request was locked and accepted by a provider we can no
longer revise it. Since the schedulers try to update all but the
fulfilled requests, we can see a lot of "Unable to revise locked node
request ..." messages in our logs.

With this change we will only attempt to revise a request when it's
still in state 'requested'.

Change-Id: I4760ab3e4337026d60f840bec677b9fd9a67a573
This commit is contained in:
Simon Westphahl 2022-04-04 14:22:52 +02:00
parent 08348143f5
commit e159b3ebd9
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
zuul/manager/__init__.py
View File

@ -1583,9 +1583,9 @@ class PipelineManager(metaclass=ABCMeta):
request_id, cached=True)
if not node_request:
continue
if node_request.fulfilled:
# If the node request is already fulfilled, there is no
# need to update the relative priority.
if node_request.state != model.STATE_REQUESTED:
# If the node request was locked and accepted by a
# provider, we can no longer update the relative priority.
continue
if node_request.relative_priority != priority:
self.sched.nodepool.reviseRequest(