zuul
/
zuul
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(2 comments)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 1 \u003c1@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"removed on reply"}
This commit is contained in:
Gerrit User 1 2022-05-16 22:53:51 +00:00 committed by Gerrit Code Review
parent 5da7cd94f1
commit e2b654ad34
1 changed files with 34 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
3c89f9e4bfdb4f659fae959728c1af7e68fd85c9
View File

@ -17,6 +17,23 @@
"revId": "3c89f9e4bfdb4f659fae959728c1af7e68fd85c9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f36ad670_c71366ab",
"filename": "zuul/model.py",
"patchSetId": 4
},
"lineNbr": 7438,
"author": {
"id": 1
},
"writtenOn": "2022-05-16T22:53:51Z",
"side": 1,
"message": "Thanks, this seems likely to be leftover.",
"revId": "3c89f9e4bfdb4f659fae959728c1af7e68fd85c9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -33,6 +50,23 @@
"message": "This seems redundant as tpc isn\u0027t used until line 2227 but we set its value again on line 2220.",
"revId": "3c89f9e4bfdb4f659fae959728c1af7e68fd85c9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b0f403af_fa5534ed",
"filename": "zuul/scheduler.py",
"patchSetId": 4
},
"lineNbr": 2182,
"author": {
"id": 1
},
"writtenOn": "2022-05-16T22:53:51Z",
"side": 1,
"message": "Agreed.",
"revId": "3c89f9e4bfdb4f659fae959728c1af7e68fd85c9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}